Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Temperature-aware physical SiDB simulation #120

Merged
merged 100 commits into from
May 12, 2023

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Feb 9, 2023

This PR adds a Temperature-aware Physical SiDB Simulator. The simulator’s underlying principle is based on the Canonical Partition Function from statistical physics. This concept is applied to simulate the Critical Temperature. It is the output of the simulator and is defined to describe at which temperature the reliable execution of SiDB-based gates cannot be guaranteed because the probability of computing the correct output falls below a given confidence level.

@marcelwa marcelwa added the enhancement New feature or request label Feb 9, 2023
@marcelwa
Copy link
Collaborator

marcelwa commented Feb 9, 2023

Please revert the changes you made to the submodules.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #120 (b961438) into main (217de04) will decrease coverage by 0.03%.
The diff coverage is 92.48%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   94.28%   94.26%   -0.03%     
==========================================
  Files          79       82       +3     
  Lines        7196     7362     +166     
==========================================
+ Hits         6785     6940     +155     
- Misses        411      422      +11     
Impacted Files Coverage Δ
...orithms/simulation/sidb/sidb_simulation_result.hpp 100.00% <ø> (ø)
include/fiction/io/write_sqd_sim_result.hpp 98.92% <ø> (ø)
...fiction/technology/charge_distribution_surface.hpp 95.27% <ø> (-0.08%) ⬇️
include/fiction/layouts/coordinates.hpp 95.30% <80.00%> (+1.22%) ⬆️
...lgorithms/simulation/sidb/critical_temperature.hpp 89.47% <89.47%> (ø)
...lation/sidb/exhaustive_ground_state_simulation.hpp 94.73% <90.00%> (+0.29%) ⬆️
...de/fiction/algorithms/simulation/sidb/quicksim.hpp 97.05% <93.33%> (-1.38%) ⬇️
.../sidb/occupation_probability_of_excited_states.hpp 96.87% <96.87%> (ø)
...imulation/sidb/calculate_energy_and_state_type.hpp 100.00% <100.00%> (ø)
...algorithms/simulation/sidb/energy_distribution.hpp 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8894a5...b961438. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Drewniok and others added 2 commits February 9, 2023 14:35
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Drewniok and others added 2 commits February 10, 2023 07:31
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa marcelwa changed the title temperature simulation ✨ Temperature-aware simulation Feb 10, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort! Looks really good. Also the integration of the new result type!

@Drewniok Drewniok requested a review from marcelwa May 1, 2023 14:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

test/algorithms/simulation/sidb/quicksim.cpp Show resolved Hide resolved
test/algorithms/simulation/sidb/quicksim.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final spurt. Mini adjustments and then we're done for good.

@Drewniok Drewniok requested a review from marcelwa May 11, 2023 08:55
@Drewniok Drewniok requested a review from marcelwa May 11, 2023 09:13
@marcelwa marcelwa changed the title ✨ Temperature-aware simulation ✨ Temperature-aware physical SiDB simulation May 11, 2023
@Drewniok Drewniok requested a review from marcelwa May 11, 2023 10:11
@marcelwa marcelwa merged commit 9414bdf into main May 12, 2023
@marcelwa marcelwa deleted the sidb_temperature_simulation branch May 12, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants