-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Temperature-aware physical SiDB simulation #120
Conversation
Signed-off-by: ClangFormat <[email protected]>
Please revert the changes you made to the submodules. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 94.28% 94.26% -0.03%
==========================================
Files 79 82 +3
Lines 7196 7362 +166
==========================================
+ Hits 6785 6940 +155
- Misses 411 422 +11
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: ClangFormat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: ClangFormat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/occupation_function_erroneous.hpp
Outdated
Show resolved
Hide resolved
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort! Looks really good. Also the integration of the new result type!
include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Fixed
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Fixed
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/occupation_probability_of_excited_states.hpp
Fixed
Show resolved
Hide resolved
test/algorithms/simulation/sidb/occupation_probability_of_excited_states.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final spurt. Mini adjustments and then we're done for good.
This PR adds a Temperature-aware Physical SiDB Simulator. The simulator’s underlying principle is based on the Canonical Partition Function from statistical physics. This concept is applied to simulate the Critical Temperature. It is the output of the simulator and is defined to describe at which temperature the reliable execution of SiDB-based gates cannot be guaranteed because the probability of computing the correct output falls below a given confidence level.