✨ Added conversion functions for layouts of different coordinate types #125

Drewniok · 2023-02-12T17:41:11Z

No description provided.

…ate type (fiction to siqad and vs.).

codecov · 2023-02-12T17:53:27Z

Codecov Report

Merging #125 (23db248) into main (da61221) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   93.87%   93.91%   +0.04%     
==========================================
  Files          75       75              
  Lines        6955     7002      +47     
==========================================
+ Hits         6529     6576      +47     
  Misses        426      426

Impacted Files	Coverage Δ
include/fiction/utils/layout_utils.hpp	`97.64% <100.00%> (+2.40%)`	⬆️
include/fiction/layouts/cell_level_layout.hpp	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da61221...23db248. Read the comment docs.

github-actions · 2023-02-12T18:03:24Z

clang-tidy review says "All clean, LGTM! 👍"

marcelwa

Thanks for the addition! Could you please address the following points:

Move both functions to /utils/layout_utils.hpp
Add respective static_asserts
Copy additional info stored in cell_level_layout to the newly created layout: inputs, outputs, cell modes, cell names, layout name
Add missing newlines at the end of each file

…d tests.

marcelwa · 2023-02-13T10:06:22Z

What happens to layouts based on SiQAD coordinates with negative values if they are to be converted to offset::ucoord_t coordinates?

Drewniok · 2023-02-13T10:13:39Z

What happens to layouts based on SiQAD coordinates with negative values if they are to be converted to offset::ucoord_t coordinates?

I mean, the function to_fiction_coord will fail, right?

marcelwa · 2023-02-13T10:22:00Z

No, it won't. It has no method to "fail". It would produce coordinates that convert negative numbers into their respective unsigned representation, i.e., 2^{31} - 1 - c, where c is the SiQAD coordinate value.

github-actions · 2023-02-13T10:48:37Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-13T10:52:53Z

clang-tidy review says "All clean, LGTM! 👍"

docs/utils/utils.rst

include/fiction/traits.hpp

include/fiction/utils/layout_utils.hpp

github-actions

clang-tidy made some suggestions

include/fiction/utils/layout_utils.hpp

github-actions · 2023-02-13T17:23:58Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-13T17:40:35Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-13T18:44:09Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-13T19:47:00Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-14T07:07:42Z

clang-tidy review says "All clean, LGTM! 👍"

include/fiction/utils/layout_utils.hpp

test/utils/layout_utils.cpp

marcelwa · 2023-02-15T10:49:51Z

Many thanks for the updates. I've performed some restructuring and added failing tests. The original layout's aspect ratio is not yet copied to the converted layouts.

github-actions · 2023-02-15T11:38:24Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-15T11:38:41Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-15T12:03:39Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-15T12:04:07Z

clang-tidy review says "All clean, LGTM! 👍"

include/fiction/utils/layout_utils.hpp

github-actions · 2023-02-16T14:15:11Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-17T16:00:07Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-02-19T10:44:23Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-03-02T15:27:06Z

clang-tidy review says "All clean, LGTM! 👍"

Drewniok added 3 commits February 12, 2023 14:02

✨ functions to convert layouts to a new layout based on a new coordin…

f76860b

…ate type (fiction to siqad and vs.).

Merge branch 'main' into siqad_coodinates_to_fiction_vs

dfa2269

✨ functions to convert layouts to a new layout based on a new coordin…

e40fbc1

…ate type (fiction to siqad and vs.).

marcelwa requested changes Feb 13, 2023

View reviewed changes

Drewniok added 2 commits February 13, 2023 10:47

🎨 put functions in different header, added missing attributes, update…

d7de6c3

…d tests.

📝 docu updated

514b990

Drewniok requested a review from marcelwa February 13, 2023 09:50

Drewniok closed this Feb 13, 2023

Drewniok reopened this Feb 13, 2023

Drewniok added 2 commits February 13, 2023 15:18

🎨 new function to shift layout to positive coordinates

2a058a3

🎨 new function to shift layout to positive coordinates

35e3728

marcelwa requested changes Feb 13, 2023

View reviewed changes

github-actions bot reviewed Feb 13, 2023

View reviewed changes

include/fiction/utils/layout_utils.hpp Outdated Show resolved Hide resolved

🎨 updated Marcel's suggestions

f46f4e3

🎨 reformat code

c258e70

Drewniok added 2 commits February 13, 2023 19:09

🎨 reformat code

8ea6c24

🎨 reformat code

1e04450

Delete sidb_surface_analysis.hpp

5139d74

Drewniok requested a review from marcelwa February 15, 2023 09:15

marcelwa requested changes Feb 15, 2023

View reviewed changes

🎨 updated Marcel's suggestions

1388803

Drewniok requested a review from marcelwa February 15, 2023 10:05

marcelwa added 5 commits February 15, 2023 11:25

📝 Adjusted docstrings

1bbf6a2

🎨 Renamed functions

abb53e5

🎨 Fixed code duplication

dd7b264

🎨 Restructured tests

432449d

🧪 Added failing tests

919ddd7

Drewniok added 2 commits February 15, 2023 12:18

🎨 aspect-ratio added for copy process

c26d134

🎨 aspect-ratio added for copy process

c3fc617

Drewniok commented Feb 16, 2023

View reviewed changes

include/fiction/utils/layout_utils.hpp Outdated Show resolved Hide resolved

Drewniok commented Feb 16, 2023

View reviewed changes

include/fiction/utils/layout_utils.hpp Show resolved Hide resolved

🎨 aspect-ratio added for copy process

bc6ed9e

Merge branch 'main' into siqad_coodinates_to_fiction_vs

04c7b66

Merge branch 'main' into siqad_coodinates_to_fiction_vs

bbb9721

Merge branch 'main' into siqad_coodinates_to_fiction_vs

23db248

marcelwa approved these changes Mar 2, 2023

View reviewed changes

marcelwa changed the title ~~convert layouts from SiQAD coordinates to fiction and vs.~~ ✨ Added conversion functions for layouts of different coordinate types Mar 2, 2023

marcelwa added the enhancement New feature or request label Mar 2, 2023

marcelwa merged commit c77a7c9 into cda-tum:main Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Added conversion functions for layouts of different coordinate types #125

✨ Added conversion functions for layouts of different coordinate types #125

Drewniok commented Feb 12, 2023

codecov bot commented Feb 12, 2023 •

edited

Loading

github-actions bot commented Feb 12, 2023

marcelwa left a comment

marcelwa commented Feb 13, 2023

Drewniok commented Feb 13, 2023 •

edited

Loading

marcelwa commented Feb 13, 2023 •

edited

Loading

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot left a comment

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 14, 2023

marcelwa commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 19, 2023

github-actions bot commented Mar 2, 2023

✨ Added conversion functions for layouts of different coordinate types #125

✨ Added conversion functions for layouts of different coordinate types #125

Conversation

Drewniok commented Feb 12, 2023

codecov bot commented Feb 12, 2023 • edited Loading

Codecov Report

github-actions bot commented Feb 12, 2023

marcelwa left a comment

Choose a reason for hiding this comment

marcelwa commented Feb 13, 2023

Drewniok commented Feb 13, 2023 • edited Loading

marcelwa commented Feb 13, 2023 • edited Loading

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 13, 2023

github-actions bot commented Feb 14, 2023

marcelwa commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 19, 2023

github-actions bot commented Mar 2, 2023

codecov bot commented Feb 12, 2023 •

edited

Loading

Drewniok commented Feb 13, 2023 •

edited

Loading

marcelwa commented Feb 13, 2023 •

edited

Loading