Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Renamed functions to more appropriately reflect their role #135

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Mar 9, 2023

Description

In this PR, one function is renamed to appropriately reflect its role. Additionally, missing tests for potential_between_sidbs are added.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #135 (1a0dbe4) into main (9412837) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   93.91%   93.92%           
=======================================
  Files          75       75           
  Lines        7000     7008    +8     
=======================================
+ Hits         6574     6582    +8     
  Misses        426      426           
Impacted Files Coverage Δ
...fiction/technology/charge_distribution_surface.hpp 94.80% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9412837...1a0dbe4. Read the comment docs.

@marcelwa marcelwa added small fix Non-critical issue or inconsistency test Tests added or missing labels Mar 9, 2023
@marcelwa marcelwa changed the title Function labeling 🩹 Renamed functions to more appropriately reflect their role Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 9819aea into main Mar 9, 2023
@marcelwa marcelwa deleted the function_labeling branch March 9, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fix Non-critical issue or inconsistency test Tests added or missing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants