-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 added a new function get_chargeless_potential_between_sidbs
#138
🎨 added a new function get_chargeless_potential_between_sidbs
#138
Conversation
…avoid confusion.
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 75 75
Lines 7008 7009 +1
=======================================
+ Hits 6582 6583 +1
Misses 426 426
Continue to review full report in Codecov by Sentry.
|
…avoid confusion.
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge if you provide test cases for the uncovered lines according to CodeCov and address CodeQL's concerns regarding floating-point comparisons in the tests.
ok, I will implement it |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
Description
In this PR, a new function
get_chargeless_potential_between_sidbs
is added, which can be used to get the chargeless potential between two cells (V_i,j / n_j).Fixes # (issue)
Checklist: