Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 added a new function get_chargeless_potential_between_sidbs #138

Merged
merged 8 commits into from
Mar 14, 2023

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Mar 10, 2023

Description

In this PR, a new function get_chargeless_potential_between_sidbs is added, which can be used to get the chargeless potential between two cells (V_i,j / n_j).

Fixes # (issue)

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #138 (0fceb87) into main (b51a274) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          75       75           
  Lines        7008     7009    +1     
=======================================
+ Hits         6582     6583    +1     
  Misses        426      426           
Impacted Files Coverage Δ
...fiction/technology/charge_distribution_surface.hpp 94.82% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8d807...0fceb87. Read the comment docs.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa added enhancement New feature or request small fix Non-critical issue or inconsistency labels Mar 12, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge if you provide test cases for the uncovered lines according to CodeCov and address CodeQL's concerns regarding floating-point comparisons in the tests.

@Drewniok
Copy link
Collaborator Author

We can merge if you provide test cases for the uncovered lines according to CodeCov and address CodeQL's concerns regarding floating-point comparisons in the tests.

ok, I will implement it

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 32bd751 into cda-tum:main Mar 14, 2023
@marcelwa marcelwa self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants