Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent manually declared layout obstructions to be cleared by the application of Yen's Algorithm #143

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Mar 15, 2023

Description

When an obstruction_layout with manually declared obstructions is fed into yen_k_shortest_paths, these obstructions are invalidated during the algorithm's run. This PR fixes the issue.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the bug Something isn't working label Mar 15, 2023
@marcelwa marcelwa self-assigned this Mar 15, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #143 (b4ff0cb) into main (9479232) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   93.92%   93.94%   +0.01%     
==========================================
  Files          75       75              
  Lines        7017     7032      +15     
==========================================
+ Hits         6591     6606      +15     
  Misses        426      426              
Impacted Files Coverage Δ
...ction/algorithms/path_finding/k_shortest_paths.hpp 100.00% <100.00%> (ø)
include/fiction/layouts/obstruction_layout.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9479232...b4ff0cb. Read the comment docs.

@marcelwa marcelwa merged commit ed35a21 into main Mar 15, 2023
@marcelwa marcelwa deleted the yens_obstruction_fix branch March 15, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant