Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Search space reduction in SiDB simulation #150

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Mar 20, 2023

Description

In this PR, a new function is introduced which can be used to detect SiDBs that have to be negatively charged due to their location.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok requested a review from marcelwa March 20, 2023 09:44
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/technology/charge_distribution_surface.hpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #150 (86162ba) into main (c2d045f) will increase coverage by 0.00%.
The diff coverage is 96.29%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   93.94%   93.95%           
=======================================
  Files          75       75           
  Lines        7032     7043   +11     
=======================================
+ Hits         6606     6617   +11     
  Misses        426      426           
Impacted Files Coverage Δ
...de/fiction/algorithms/simulation/sidb/quicksim.hpp 98.41% <94.44%> (+0.13%) ⬆️
...fiction/technology/charge_distribution_surface.hpp 94.94% <100.00%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf581b3...86162ba. Read the comment docs.

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just some more minor comments

include/fiction/algorithms/simulation/sidb/quicksim.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/quicksim.hpp Outdated Show resolved Hide resolved
include/fiction/technology/charge_distribution_surface.hpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok enabled auto-merge (squash) March 20, 2023 15:02
@marcelwa marcelwa changed the title Reducing search space ⚡ Search space reduction in SiDB simulation Mar 20, 2023
@marcelwa marcelwa merged commit eb84d7a into cda-tum:main Mar 20, 2023
@marcelwa marcelwa self-assigned this Mar 24, 2023
@marcelwa marcelwa added enhancement New feature or request performance Performance improvements labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants