Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fixed warnings and notes brought up by CodeQL #151

Merged
merged 10 commits into from
Mar 23, 2023
Merged

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Mar 22, 2023

Description

This PR fixes warnings and notes by CodeQL. Furthermore, some overly strict CodeQL checks have been disabled because they lead to false positives.

Fixes #140

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the small fix Non-critical issue or inconsistency label Mar 22, 2023
@marcelwa marcelwa self-assigned this Mar 22, 2023
Signed-off-by: ClangFormat <[email protected]>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #151 (ea659fe) into main (ebe0543) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   94.00%   93.98%   -0.02%     
==========================================
  Files          76       76              
  Lines        7085     7084       -1     
==========================================
- Hits         6660     6658       -2     
- Misses        425      426       +1     
Impacted Files Coverage Δ
include/fiction/layouts/bounding_box.hpp 100.00% <ø> (ø)
...clude/fiction/algorithms/physical_design/exact.hpp 89.37% <100.00%> (-0.03%) ⬇️
.../algorithms/physical_design/one_pass_synthesis.hpp 88.19% <100.00%> (-0.35%) ⬇️
...de/fiction/algorithms/simulation/sidb/quicksim.hpp 98.43% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5dc4dd...ea659fe. Read the comment docs.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 6172445 into main Mar 23, 2023
@marcelwa marcelwa deleted the codeql-fixes branch March 23, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security warnings and notes
1 participant