Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Removed excess template parameter typename T #162

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Mar 27, 2023

Description

Remove excess template parameter T when invoking restore_names() without a mapping of signals from ntk_src to ntk_dest.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa self-assigned this Mar 27, 2023
@marcelwa marcelwa added bug Something isn't working small fix Non-critical issue or inconsistency labels Mar 27, 2023
@marcelwa marcelwa changed the title 🐛 remove excess template parameter typename T 🐛 Removed excess template parameter typename T Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #162 (1b56d1d) into main (d501570) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          76       76           
  Lines        7070     7070           
=======================================
  Hits         6663     6663           
  Misses        407      407           
Impacted Files Coverage Δ
include/fiction/utils/name_utils.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d501570...1b56d1d. Read the comment docs.

@marcelwa marcelwa merged commit acbe7aa into cda-tum:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants