Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Restructured sidb_charge_state and added tests #168

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Mar 29, 2023

Description

This PR adds tests for the functions associated with sidb_charge_state and restructures the respective header a bit.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the test Tests added or missing label Mar 29, 2023
@marcelwa marcelwa self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #168 (72b0128) into main (acbe7aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          76       76           
  Lines        7070     7088   +18     
=======================================
+ Hits         6663     6680   +17     
- Misses        407      408    +1     
Impacted Files Coverage Δ
.../fiction/algorithms/iter/aspect_ratio_iterator.hpp 100.00% <ø> (ø)
...n/algorithms/verification/equivalence_checking.hpp 89.79% <ø> (ø)
include/fiction/technology/sidb_charge_state.hpp 91.89% <100.00%> (+2.41%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449ba03...72b0128. Read the comment docs.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 4eed6a3 into main Mar 29, 2023
@marcelwa marcelwa deleted the sidb-charge-state-update branch March 29, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Tests added or missing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant