Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Made the DOT drawer tests independent of the version number #170

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Mar 30, 2023

Description

This PR fixes an inconsistency with the DOT drawer tests that had fiction's version number still hard-coded.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added small fix Non-critical issue or inconsistency test Tests added or missing labels Mar 30, 2023
@marcelwa marcelwa self-assigned this Mar 30, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #170 (a6baac7) into main (4eed6a3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          76       76           
  Lines        7088     7088           
=======================================
  Hits         6680     6680           
  Misses        408      408           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eed6a3...a6baac7. Read the comment docs.

@marcelwa marcelwa merged commit 5bfe361 into main Mar 30, 2023
@marcelwa marcelwa deleted the dot-drawer-test-fix branch March 30, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fix Non-critical issue or inconsistency test Tests added or missing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant