Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed port routing determination for unconnected gates in the Bestagon library #212

Merged
merged 1 commit into from
May 17, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented May 17, 2023

Description

When using the Bestagon gate library, it was impossible to map gates without connections. This has been fixed. Many thanks to @wlambooy for reporting!

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the bug Something isn't working label May 17, 2023
@marcelwa marcelwa self-assigned this May 17, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@40f5361). Click here to learn what that means.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage        ?   94.24%           
=======================================
  Files           ?       82           
  Lines           ?     7367           
  Branches        ?        0           
=======================================
  Hits            ?     6943           
  Misses          ?      424           
  Partials        ?        0           
Impacted Files Coverage Δ
...clude/fiction/technology/sidb_bestagon_library.hpp 90.90% <66.66%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f5361...140b3f8. Read the comment docs.

@marcelwa marcelwa merged commit 74bbde9 into main May 17, 2023
@marcelwa marcelwa deleted the bestagon-fix branch May 17, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant