Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ISCAS85 and EPFL benchmarks #221

Merged
merged 5 commits into from
May 23, 2023

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented May 22, 2023

Description

Added ISCAS85 and EPFL benchmarks to fiction experiments.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

experiments/fiction_experiments.hpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #221 (e662bee) into main (cc6075b) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   94.39%   94.31%   -0.09%     
==========================================
  Files          82       82              
  Lines        7406     7406              
==========================================
- Hits         6991     6985       -6     
- Misses        415      421       +6     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6075b...e662bee. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

experiments/fiction_experiments.hpp Outdated Show resolved Hide resolved
experiments/fiction_experiments.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! 🙏

@marcelwa marcelwa added the enhancement New feature or request label May 23, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 27223ad into cda-tum:main May 23, 2023
@simon1hofmann simon1hofmann deleted the add_benchmarks branch October 6, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants