Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed wrong SiDB locations in a Bestagon tile's input wire #224

Merged

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented May 24, 2023

Description

The input wire of the mirrored version of the straight wire from the bestagon gate library had a wrong position (shifted by one atom position).

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

dependabot bot and others added 21 commits April 2, 2023 15:38
Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`.
- [Release notes](https://github.com/catchorg/Catch2/releases)
- [Commits](catchorg/Catch2@6783411...1f881ab)

---
updated-dependencies:
- dependency-name: libs/Catch2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `7883cb6` to `d2bed96`.
- [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases)
- [Commits](greg7mdp/parallel-hashmap@7883cb6...d2bed96)

---
updated-dependencies:
- dependency-name: libs/parallel-hashmap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Drewniok Drewniok added the bug Something isn't working label May 24, 2023
@Drewniok Drewniok self-assigned this May 24, 2023
@Drewniok Drewniok requested a review from marcelwa May 24, 2023 16:19
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #224 (55916c1) into main (6a58846) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   94.41%   94.42%   +0.01%     
==========================================
  Files          82       82              
  Lines        7431     7431              
==========================================
+ Hits         7016     7017       +1     
+ Misses        415      414       -1     
Impacted Files Coverage Δ
...clude/fiction/technology/sidb_bestagon_library.hpp 95.45% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a58846...55916c1. Read the comment docs.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the fix!

@marcelwa marcelwa changed the title 🐛 Wrong sidb location of input wire (bestagon) 🐛 Fixed wrong SiDB locations in a Bestagon tile's input wire May 25, 2023
@marcelwa marcelwa merged commit 0552941 into cda-tum:main May 25, 2023
@Drewniok Drewniok deleted the wrong_sidb_location_input_wire_bestagon_wire branch September 5, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants