Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added a unified print_layout function #240

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Jun 20, 2023

Description

This PR introduces a unified print_layout function that is easier to use than the previous ones.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the enhancement New feature or request label Jun 20, 2023
@marcelwa marcelwa self-assigned this Jun 20, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #240 (650c7e0) into main (12fdfc3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   94.53%   94.55%   +0.01%     
==========================================
  Files          83       83              
  Lines        7581     7586       +5     
==========================================
+ Hits         7167     7173       +6     
+ Misses        414      413       -1     
Impacted Files Coverage Δ
include/fiction/io/print_layout.hpp 95.13% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fdfc3...650c7e0. Read the comment docs.

@marcelwa marcelwa merged commit b352aaf into main Jun 22, 2023
56 checks passed
@marcelwa marcelwa deleted the unified-print-layout branch June 22, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant