Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ MIG inverter optimization and propagation #248

Merged
merged 5 commits into from
Nov 21, 2023
Merged

✨ MIG inverter optimization and propagation #248

merged 5 commits into from
Nov 21, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Jul 11, 2023

Description

This PR introduces two algorithms from mockturlte to fiction's CLI: MIG inverter optimization and MIG inverter propagation. They are targeted at reducing the number of inverters in a given MIG.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added enhancement New feature or request cli Concerning the command-line interface (CLI) labels Jul 11, 2023
@marcelwa marcelwa requested a review from hibenj July 11, 2023 08:35
@marcelwa marcelwa self-assigned this Jul 11, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cli/cmd/logic/miginvopt.hpp Show resolved Hide resolved
cli/cmd/logic/miginvprop.hpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (926c895) 96.03% compared to head (c521127) 96.04%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files         102      102           
  Lines       10073    10073           
=======================================
+ Hits         9674     9675    +1     
+ Misses        399      398    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelwa marcelwa merged commit 3fd13f3 into main Nov 21, 2023
59 checks passed
@marcelwa marcelwa deleted the inv-opt branch November 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerning the command-line interface (CLI) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants