Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support defects in print function. #261

Merged
merged 61 commits into from
Aug 30, 2023

Conversation

Drewniok
Copy link
Collaborator

Description

This PR adds defects to the print_layout function.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

dependabot bot and others added 30 commits April 2, 2023 15:38
Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`.
- [Release notes](https://github.com/catchorg/Catch2/releases)
- [Commits](catchorg/Catch2@6783411...1f881ab)

---
updated-dependencies:
- dependency-name: libs/Catch2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `7883cb6` to `d2bed96`.
- [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases)
- [Commits](greg7mdp/parallel-hashmap@7883cb6...d2bed96)

---
updated-dependencies:
- dependency-name: libs/parallel-hashmap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Drewniok Drewniok requested a review from marcelwa July 28, 2023 13:08
test/io/print_layout.cpp Dismissed Show dismissed Hide dismissed
test/io/print_layout.cpp Dismissed Show dismissed Hide dismissed
include/fiction/io/print_layout.hpp Show resolved Hide resolved
include/fiction/io/print_layout.hpp Outdated Show resolved Hide resolved
include/fiction/io/print_layout.hpp Outdated Show resolved Hide resolved
include/fiction/io/print_layout.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Outdated Show resolved Hide resolved
include/fiction/utils/layout_utils.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/io/print_layout.hpp Show resolved Hide resolved
include/fiction/layouts/bounding_box.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved
test/io/print_layout.cpp Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa August 29, 2023 04:59
include/fiction/layouts/bounding_box.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Outdated Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa August 29, 2023 15:19
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved
include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved
@Drewniok Drewniok merged commit 73c662f into cda-tum:main Aug 30, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants