Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Refactored the hexagonalization algorithm #316

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

simon1hofmann
Copy link
Collaborator

Description

New features:

  • automatically remove empty columns on the left- and right-hand side of the hexagonal layout
  • save runtime in a statistics object
  • refactored types

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann added the enhancement New feature or request label Oct 23, 2023
@simon1hofmann simon1hofmann self-assigned this Oct 23, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@simon1hofmann simon1hofmann changed the title ✨Updated the hexagonalization algorithm ✨Refactored the hexagonalization algorithm Oct 23, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ea5e9e) 96.00% compared to head (341ee4f) 96.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   96.00%   96.03%   +0.03%     
==========================================
  Files         100      100              
  Lines        9935     9962      +27     
==========================================
+ Hits         9538     9567      +29     
+ Misses        397      395       -2     
Files Coverage Δ
...on/algorithms/physical_design/hexagonalization.hpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 2778d65 into cda-tum:main Oct 26, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants