Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix VSC builds #320

Merged
merged 1 commit into from
Oct 30, 2023
Merged

💚 Fix VSC builds #320

merged 1 commit into from
Oct 30, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Oct 30, 2023

Description

This PR fixes a problem with VSC builds due to a missing CMake include.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the bug Something isn't working label Oct 30, 2023
@marcelwa marcelwa self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8afd6c) 96.02% compared to head (922375e) 96.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   96.02%   96.03%   +0.01%     
==========================================
  Files         100      100              
  Lines        9963     9963              
==========================================
+ Hits         9567     9568       +1     
+ Misses        396      395       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelwa marcelwa merged commit 7287389 into main Oct 30, 2023
57 checks passed
@marcelwa marcelwa deleted the vsc-cmake-fix branch October 30, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant