Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Correct y-direction boundary for Moore neighborhood #331

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Drewniok
Copy link
Collaborator

Description

This PR uses the correct y-direction boundary for Moore neighborhood. An appropriate test is added.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok changed the title 🐛 Wrong y-direction boundary for Moore neighborhood 🐛 Use correct y-direction boundary for Moore neighborhood Nov 15, 2023
@Drewniok Drewniok changed the title 🐛 Use correct y-direction boundary for Moore neighborhood 🐛 Correct y-direction boundary for Moore neighborhood Nov 15, 2023
@Drewniok Drewniok self-assigned this Nov 15, 2023
@Drewniok Drewniok added the bug Something isn't working label Nov 15, 2023
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good catch! Thank you 🙏

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e25b188) 96.02% compared to head (7f6b343) 96.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   96.02%   96.04%   +0.02%     
==========================================
  Files         100      100              
  Lines        9974     9974              
==========================================
+ Hits         9578     9580       +2     
+ Misses        396      394       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 92ee896 into cda-tum:main Nov 15, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants