Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Allow fiction coordinates for simulation and other functions. #336

Merged
merged 10 commits into from
Nov 27, 2023
Merged

🎨 Allow fiction coordinates for simulation and other functions. #336

merged 10 commits into from
Nov 27, 2023

Conversation

Drewniok
Copy link
Collaborator

Description

This PR makes it possible to use fiction coordinates for simulation.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Nov 21, 2023
@Drewniok Drewniok self-assigned this Nov 21, 2023
@Drewniok Drewniok changed the title 🎨 fiction coordinates for simulation and other functions. 🎨 Allow fiction coordinates for simulation and other functions. Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Merging #336 (776f60b) into main (14d3d71) will increase coverage by 0.01%.
The diff coverage is 97.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   96.04%   96.06%   +0.01%     
==========================================
  Files         102      102              
  Lines       10075    10086      +11     
==========================================
+ Hits         9677     9689      +12     
+ Misses        398      397       -1
Files Coverage Δ
...ude/fiction/algorithms/iter/bdl_input_iterator.hpp 100.00% <ø> (ø)
...clude/fiction/algorithms/path_finding/distance.hpp 100.00% <ø> (ø)
...tion/sidb/assess_physical_population_stability.hpp 96.59% <ø> (ø)
...imulation/sidb/calculate_energy_and_state_type.hpp 100.00% <ø> (ø)
...on/algorithms/simulation/sidb/detect_bdl_pairs.hpp 100.00% <ø> (ø)
...ion/algorithms/simulation/sidb/is_ground_state.hpp 100.00% <ø> (ø)
...tion/algorithms/simulation/sidb/is_operational.hpp 96.29% <ø> (-1.86%) ⬇️
...maximum_defect_influence_position_and_distance.hpp 100.00% <100.00%> (ø)
.../algorithms/simulation/sidb/operational_domain.hpp 98.04% <ø> (+0.39%) ⬆️
.../fiction/algorithms/simulation/sidb/quickexact.hpp 98.88% <100.00%> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d3d71...776f60b. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

marcelwa
marcelwa requested changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the thorough changes. I have only a few comments.

include/fiction/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/quickexact.hpp Show resolved Hide resolved
include/fiction/layouts/bounding_box.hpp Show resolved Hide resolved
include/fiction/layouts/coordinates.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_nm_position.hpp Outdated Show resolved Hide resolved
test/technology/sidb_nm_position.cpp Outdated Show resolved Hide resolved
test/technology/sidb_nm_position.cpp Outdated Show resolved Hide resolved
include/fiction/utils/layout_utils.hpp Outdated Show resolved Hide resolved
include/fiction/utils/layout_utils.hpp Outdated Show resolved Hide resolved
include/fiction/utils/layout_utils.hpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 8e61624 into cda-tum:main Nov 27, 2023
58 checks passed
@Drewniok Drewniok deleted the avoid_siqad_coordinates_in_simulation branch July 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

Assignees

@Drewniok Drewniok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drewniok @marcelwa