Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Place inputs and outputs in the same order during hexagonalization #342

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Nov 28, 2023

Description

Inputs and outputs have to be placed in the same order as specified in the network/ Cartesian layout.

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann self-assigned this Nov 28, 2023
@simon1hofmann simon1hofmann changed the title 🐛 Place inputs in the same ordering during hexagonalization 🐛 Place inputs in the same order during hexagonalization Nov 28, 2023
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #342 (2024d61) into main (481331f) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   96.06%   96.05%   -0.01%     
==========================================
  Files         102      102              
  Lines       10086    10100      +14     
==========================================
+ Hits         9689     9702      +13     
- Misses        397      398       +1     
Files Coverage Δ
...on/algorithms/physical_design/hexagonalization.hpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb380a...2024d61. Read the comment docs.

@simon1hofmann simon1hofmann changed the title 🐛 Place inputs in the same order during hexagonalization 🐛 Place inputs and outputs in the same order during hexagonalization Nov 28, 2023
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa added the bug Something isn't working label Nov 30, 2023
@marcelwa marcelwa merged commit 098fcd1 into cda-tum:main Nov 30, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants