Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 The critical temperature value will only be overwritten by the new value if the new value is lower. #343

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

Drewniok
Copy link
Collaborator

Description

This PR fixes a bug in the critical temperature simulation. The critical temperature value for a given input combination is only overwritten by the new value if the new value is lower.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok self-assigned this Nov 30, 2023
@Drewniok Drewniok added the bug Something isn't working label Nov 30, 2023
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok removed the request for review from marcelwa November 30, 2023 12:56
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #343 (c4f842b) into main (098fcd1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   96.05%   96.04%   -0.02%     
==========================================
  Files         102      102              
  Lines       10100    10101       +1     
==========================================
- Hits         9702     9701       -1     
- Misses        398      400       +2     
Files Coverage Δ
...lgorithms/simulation/sidb/critical_temperature.hpp 97.45% <100.00%> (-1.69%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098fcd1...c4f842b. Read the comment docs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok merged commit 07d5712 into cda-tum:main Nov 30, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants