Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 read_sqd_layout now updates the aspect ratio properly for SiQAD-coordinate based layouts #355

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

wlambooy
Copy link
Contributor

@wlambooy wlambooy commented Dec 13, 2023

Description

read_sqd_layout now updates the aspect ratio properly for SiQAD-coordinate based layouts

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #355 (408b4e9) into main (2cb1547) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   96.04%   96.05%           
=======================================
  Files         102      102           
  Lines       10101    10106    +5     
=======================================
+ Hits         9702     9707    +5     
  Misses        399      399           
Files Coverage Δ
include/fiction/io/read_sqd_layout.hpp 99.27% <100.00%> (+0.77%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb1547...408b4e9. Read the comment docs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa self-requested a review December 13, 2023 15:14
@marcelwa marcelwa added the bug Something isn't working label Dec 13, 2023
@marcelwa marcelwa merged commit 4745f7f into cda-tum:main Dec 13, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants