Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added an upper bound option for the total layout area to exact #360

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

marcelwa
Copy link
Collaborator

Description

This PR adds an upper bound option for the total layout area to exact physical design.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added enhancement New feature or request cli Concerning the command-line interface (CLI) labels Dec 21, 2023
@marcelwa marcelwa self-assigned this Dec 21, 2023
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6d48b73) 96.06% compared to head (a3a5ab9) 96.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   96.06%   96.07%   +0.01%     
==========================================
  Files         102      102              
  Lines       10112    10115       +3     
==========================================
+ Hits         9714     9718       +4     
+ Misses        398      397       -1     
Files Coverage Δ
...clude/fiction/algorithms/physical_design/exact.hpp 89.49% <75.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d48b73...a3a5ab9. Read the comment docs.

Copy link
Collaborator

@simon1hofmann simon1hofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the addition 👍

@marcelwa marcelwa merged commit cd971f0 into main Dec 21, 2023
57 of 58 checks passed
@marcelwa marcelwa deleted the exact-upper-bound-area branch December 21, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerning the command-line interface (CLI) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants