Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix floating-point errors. #363

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Jan 8, 2024

Description

This PR fixes a potential floating-point error when converting a parameter point to a step point.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the bug Something isn't working label Jan 8, 2024
@Drewniok Drewniok self-assigned this Jan 8, 2024
@Drewniok Drewniok requested a review from marcelwa January 8, 2024 08:33
@Drewniok Drewniok changed the title 🎨 Fix floating-point errors. 🐛 Fix floating-point errors. Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3450f49) 96.06% compared to head (fe0b091) 96.06%.

❗ Current head fe0b091 differs from pull request most recent head bdfc23c. Consider uploading reports for the commit bdfc23c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         102      102           
  Lines       10115    10118    +3     
=======================================
+ Hits         9717     9720    +3     
  Misses        398      398           
Files Coverage Δ
.../algorithms/simulation/sidb/operational_domain.hpp 97.68% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3450f49...bdfc23c. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from marcelwa January 9, 2024 11:08
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Many thanks! 🙏

@marcelwa marcelwa merged commit b5b3796 into cda-tum:main Jan 9, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants