-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix floating-point errors. #363
🐛 Fix floating-point errors. #363
Conversation
include/fiction/algorithms/simulation/sidb/operational_domain.hpp
Outdated
Show resolved
Hide resolved
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 102 102
Lines 10115 10118 +3
=======================================
+ Hits 9717 9720 +3
Misses 398 398
Continue to review full report in Codecov by Sentry.
|
include/fiction/algorithms/simulation/sidb/operational_domain.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/operational_domain.hpp
Outdated
Show resolved
Hide resolved
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. Many thanks! 🙏
Description
This PR fixes a potential floating-point error when converting a parameter point to a step point.
Checklist: