Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add round-function to mitigate floating precision issues #375

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

This PR adds std::round() to mitigate floating point errors.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the bug Something isn't working label Jan 30, 2024
@Drewniok Drewniok self-assigned this Jan 30, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08b8676) 96.07% compared to head (b289113) 96.07%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         102      102           
  Lines       10133    10133           
=======================================
  Hits         9735     9735           
  Misses        398      398           
Files Coverage Δ
.../algorithms/simulation/sidb/operational_domain.hpp 97.70% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b8676...b289113. Read the comment docs.

@Drewniok Drewniok merged commit dc1b8e2 into cda-tum:main Jan 31, 2024
58 checks passed
@Drewniok Drewniok deleted the floating_point_erro_op_domain_step branch January 31, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants