Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Usability improvement by return type adjustments #395

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Mar 11, 2024

Description

This PR enhances the usability of a couple of older functions by adding return values. This breaks legacy code.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added enhancement New feature or request small fix Non-critical issue or inconsistency labels Mar 11, 2024
@marcelwa marcelwa self-assigned this Mar 11, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 21afbcf into main Mar 19, 2024
60 checks passed
@marcelwa marcelwa deleted the equiv-return branch March 19, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant