✨ Algorithm for finding valid physical parameters for a given charge distribution. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/algorithms/sidb_simulation.rst # include/fiction/technology/charge_distribution_surface.hpp # test/algorithms/simulation/sidb/operational_domain.cpp
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 98.22% 98.21% -0.01%
==========================================
Files 214 216 +2
Lines 28961 29155 +194
Branches 1379 1389 +10
==========================================
+ Hits 28448 28636 +188
- Misses 513 519 +6
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
marcelwa
reviewed
Jul 17, 2024
marcelwa
reviewed
Jul 18, 2024
include/fiction/algorithms/simulation/sidb/operational_domain.hpp
Outdated
Show resolved
Hide resolved
marcelwa
previously approved these changes
Jul 18, 2024
Signed-off-by: GitHub Actions <[email protected]>
marcelwa
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This algorithm provides a highly efficient method for determining the physical parameters that make a given charge distribution physically valid. It also provides the excited state number for a given charge distribution. Thus, for a given physical parameter that makes the cds physically valid, it also provides information about whether the cds is the ground state or the n-th excited state.
This algorithm can be useful for extracting current physical parameters from AFM measurements.
Checklist: