Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added truth table helpers for 3-input functions #430

Merged
merged 6 commits into from
May 10, 2024
Merged

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented May 10, 2024

Description

This PR adds several helper functions to create truth tables for some 3-input Boolean functions. The selection is based on D. S. Marakkalage et al. "Three-Input Gates for Logic Synthesis" in TCAD, 2021.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

marcelwa and others added 3 commits May 10, 2024 11:54
…PN class based on the paper "Three-Input Gates for Logic Synthesis" by D. S. Marakkalage et al.
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa marcelwa changed the title ✨ Added truth table helpers for 3-input gates ✨ Added truth table helpers for 3-input functions May 10, 2024
@marcelwa marcelwa self-assigned this May 10, 2024
@marcelwa marcelwa added the enhancement New feature or request label May 10, 2024
@marcelwa marcelwa requested a review from Drewniok May 10, 2024 10:00
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (ec465b8) to head (a3aa4ed).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   98.23%   98.18%   -0.05%     
==========================================
  Files         214      214              
  Lines       28876    28874       -2     
  Branches     1366     1367       +1     
==========================================
- Hits        28367    28351      -16     
- Misses        509      523      +14     
Files Coverage Δ
include/fiction/utils/truth_table_utils.hpp 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec465b8...a3aa4ed. Read the comment docs.

@marcelwa marcelwa requested a review from Drewniok May 10, 2024 11:12
docs/utils/utils.rst Outdated Show resolved Hide resolved
@marcelwa marcelwa requested a review from Drewniok May 10, 2024 11:15
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa requested a review from Drewniok May 10, 2024 11:50
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@Drewniok Drewniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! 🙏

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit d869a2f into main May 10, 2024
44 checks passed
@marcelwa marcelwa deleted the three-input-gates branch May 10, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants