Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Added a runtime experiment script. #441

Merged

Conversation

Drewniok
Copy link
Collaborator

Description

This PR adds a script for an experiment to measure the runtime of ExGS and QuickExact and the time-to-solution of QuickSim for the Bestagon gates.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label May 19, 2024
@Drewniok Drewniok self-assigned this May 19, 2024
@Drewniok Drewniok requested a review from marcelwa May 19, 2024 11:26
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (0ef32bf) to head (e40b903).
Report is 47 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         214      214           
  Lines       28876    28876           
  Branches     1367     1367           
=======================================
  Hits        28361    28361           
  Misses        515      515           
Files Coverage Δ
...on/algorithms/simulation/sidb/time_to_solution.hpp 97.29% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 246268c...e40b903. Read the comment docs.

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. I have a few comments, but they are non-critical. Feel free to ignore them.

experiments/sidb_simulation/runtime_analysis.cpp Outdated Show resolved Hide resolved
experiments/sidb_simulation/runtime_analysis.cpp Outdated Show resolved Hide resolved
experiments/sidb_simulation/runtime_analysis.cpp Outdated Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa May 20, 2024 13:37
@Drewniok Drewniok merged commit 6823123 into cda-tum:main May 20, 2024
59 checks passed
@Drewniok Drewniok deleted the add_simulator_runtime_experiment_script branch July 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants