Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐍 Minor fixes and change of template parameter of BDL pairs. #442

Merged
merged 10 commits into from
May 20, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

This PR introduces some minor fixes in pyfiction. Also, it is no longer needed to distinguish between the 100 and 111 SiDB lattice when detecting BDL pairs.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok self-assigned this May 20, 2024
@Drewniok Drewniok requested a review from marcelwa May 20, 2024 10:56
@Drewniok Drewniok added the enhancement New feature or request label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (6823123) to head (605528e).
Report is 45 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   98.21%   98.22%           
=======================================
  Files         214      214           
  Lines       28876    28877    +1     
  Branches     1368     1367    -1     
=======================================
+ Hits        28362    28363    +1     
  Misses        514      514           
Files Coverage Δ
...ude/fiction/algorithms/iter/bdl_input_iterator.hpp 100.00% <ø> (ø)
...n/algorithms/physical_design/design_sidb_gates.hpp 100.00% <100.00%> (ø)
...imulation/sidb/calculate_energy_and_state_type.hpp 100.00% <ø> (ø)
...on/algorithms/simulation/sidb/detect_bdl_pairs.hpp 100.00% <100.00%> (ø)
...tion/algorithms/simulation/sidb/is_operational.hpp 93.25% <ø> (ø)
.../algorithms/simulation/sidb/operational_domain.hpp 97.20% <ø> (+0.40%) ⬆️
...t/algorithms/physical_design/design_sidb_gates.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6823123...605528e. Read the comment docs.

@Drewniok Drewniok requested a review from marcelwa May 20, 2024 13:26
@Drewniok Drewniok requested a review from marcelwa May 20, 2024 13:43
@Drewniok Drewniok enabled auto-merge (squash) May 20, 2024 17:44
@Drewniok Drewniok merged commit f128aec into cda-tum:main May 20, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants