-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Graph-Oriented Layout Design (GOLD) #456
Conversation
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 98.22% 98.26% +0.03%
==========================================
Files 216 220 +4
Lines 29164 30042 +878
Branches 1392 1470 +78
==========================================
+ Hits 28647 29520 +873
- Misses 517 522 +5
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
experiments/graph_oriented_layout_design/graph_oriented_layout_design.cpp
Outdated
Show resolved
Hide resolved
experiments/graph_oriented_layout_design/graph_oriented_layout_design.cpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcel Walter <[email protected]> Signed-off-by: simon1hofmann <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Show resolved
Hide resolved
…n GOLD's CLI command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your hard work on this PR 🙏 We are almost there. I just spotted a few issues and minor inconsistencies. After they have been addressed, it is finally ready for merging :)
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/graph_oriented_layout_design.hpp
Outdated
Show resolved
Hide resolved
test/algorithms/physical_design/graph_oriented_layout_design.cpp
Outdated
Show resolved
Hide resolved
test/algorithms/physical_design/graph_oriented_layout_design.cpp
Outdated
Show resolved
Hide resolved
test/algorithms/physical_design/graph_oriented_layout_design.cpp
Outdated
Show resolved
Hide resolved
experiments/graph_oriented_layout_design/graph_oriented_layout_design.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcel Walter <[email protected]> Signed-off-by: simon1hofmann <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many, many thanks for your hard work on this algorithm and the PR! 🙏
Description
Checklist: