Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Graph-Oriented Layout Design (GOLD) #456

Merged
merged 89 commits into from
Aug 9, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Jun 12, 2024

Description

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann marked this pull request as draft June 12, 2024 15:47
@simon1hofmann simon1hofmann self-assigned this Jun 12, 2024
@simon1hofmann simon1hofmann added the enhancement New feature or request label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (8f61ecc) to head (c5bd548).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   98.22%   98.26%   +0.03%     
==========================================
  Files         216      220       +4     
  Lines       29164    30042     +878     
  Branches     1392     1470      +78     
==========================================
+ Hits        28647    29520     +873     
- Misses        517      522       +5     
Files Coverage Δ
...clude/fiction/algorithms/physical_design/exact.hpp 89.54% <ø> (ø)
...s/physical_design/graph_oriented_layout_design.hpp 100.00% <100.00%> (ø)
.../fiction/algorithms/physical_design/orthogonal.hpp 96.36% <ø> (ø)
...s/physical_design/graph_oriented_layout_design.cpp 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f61ecc...c5bd548. Read the comment docs.

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your hard work on this PR 🙏 We are almost there. I just spotted a few issues and minor inconsistencies. After they have been addressed, it is finally ready for merging :)

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many, many thanks for your hard work on this algorithm and the PR! 🙏

@marcelwa marcelwa merged commit b359ee5 into cda-tum:main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants