Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed multiple post_layout_optimization bugs #472

Merged
merged 25 commits into from
Jul 18, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Jul 9, 2024

Description

Fixed two bugs in post_layout_optimization:

  • Calculation of the minimal border for the relocation of POs
  • Maximum number of gate relocations for POs should not be limited

Fixed a special case in wiring_reduction for double fanin gates:

In a layout, a structure like this can appear:

+ → =
↓   ↓
=   =
↓   ↓
= → &

Using A*, two paths can be found for deletion, which leads to:
+ → &

Therefore, the wire to the left of the AND gate is blocked so only one path can be found.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann self-assigned this Jul 9, 2024
@simon1hofmann simon1hofmann added the bug Something isn't working label Jul 9, 2024
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please adjust the PR description? Currently, it is misformed.

Additionally, it would be great to explain in the description how the bug could be reproduced or triggered. If you want, you could open a respective issue instead and link to that here.

…ation.hpp

Co-authored-by: Marcel Walter <[email protected]>
Signed-off-by: simon1hofmann <[email protected]>
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (c7aa98c) to head (aae1b3c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   98.22%   98.23%           
=======================================
  Files         214      214           
  Lines       28904    28959   +55     
  Branches     1369     1380   +11     
=======================================
+ Hits        28391    28447   +56     
+ Misses        513      512    -1     
Files Coverage Δ
...ithms/physical_design/post_layout_optimization.hpp 100.00% <100.00%> (ø)
...on/algorithms/physical_design/wiring_reduction.hpp 98.69% <100.00%> (+0.03%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6034ee...aae1b3c. Read the comment docs.

@marcelwa marcelwa changed the title 🐛 Multiple post_layout_optimization bugs 🐛 Fixed multiple post_layout_optimization bugs Jul 18, 2024
@marcelwa marcelwa merged commit 222a86d into cda-tum:main Jul 18, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants