✨ QuickCell: An Algorithm for Automatic Standard Cell Design #481

Drewniok · 2024-07-22T09:06:51Z

Description

This PR adds QuickCell, an algorithm for automatic standard cell design for SiDB logic that uses dedicated search space pruning techniques.

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have added a changelog entry.
I have created/adjusted the Python bindings for any new or updated functionality.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: GitHub Actions <[email protected]>

codecov · 2024-07-22T16:26:58Z

Codecov Report

Attention: Patch coverage is 98.74670% with 19 lines in your changes missing coverage. Please review.

Project coverage is 98.18%. Comparing base (2957b0c) to head (307fd37).

Files with missing lines	Patch %	Lines
...on/algorithms/simulation/sidb/detect_bdl_wires.hpp	91.93%	10 Missing ⚠️
...n/algorithms/physical_design/design_sidb_gates.hpp	98.88%	3 Missing ⚠️
...tion/algorithms/simulation/sidb/is_operational.hpp	97.70%	2 Missing ⚠️
test/algorithms/iter/bdl_input_iterator.cpp	94.87%	2 Missing ⚠️
.../algorithms/simulation/sidb/operational_domain.cpp	93.75%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             main     #481     +/-   ##
=========================================
  Coverage   98.17%   98.18%             
=========================================
  Files         224      226      +2     
  Lines       31600    32730   +1130     
  Branches     1575     1670     +95     
=========================================
+ Hits        31023    32135   +1112     
- Misses        577      595     +18

Files with missing lines	Coverage Δ
...ude/fiction/algorithms/iter/bdl_input_iterator.hpp	`100.00% <100.00%> (ø)`
...lgorithms/simulation/sidb/critical_temperature.hpp	`97.32% <100.00%> (+0.02%)`	⬆️
...on/algorithms/simulation/sidb/detect_bdl_pairs.hpp	`100.00% <100.00%> (ø)`
...simulation/sidb/displacement_robustness_domain.hpp	`97.53% <100.00%> (ø)`
...algorithms/simulation/sidb/energy_distribution.hpp	`100.00% <ø> (ø)`
...lation/sidb/exhaustive_ground_state_simulation.hpp	`94.44% <ø> (ø)`
.../algorithms/simulation/sidb/operational_domain.hpp	`94.32% <100.00%> (-0.38%)`	⬇️
.../fiction/algorithms/simulation/sidb/quickexact.hpp	`100.00% <ø> (+1.21%)`	⬆️
...de/fiction/algorithms/simulation/sidb/quicksim.hpp	`98.61% <ø> (ø)`
...s/simulation/sidb/random_sidb_layout_generator.hpp	`95.74% <100.00%> (+0.18%)`	⬆️
... and 29 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2957b0c...307fd37. Read the comment docs.

Signed-off-by: GitHub Actions <[email protected]>

# Conflicts: # bindings/pyfiction/pyfiction.cpp # cli/cmd/simulation/opdom.hpp # experiments/operational_domain/operational_domain_siqad.cpp # include/fiction/algorithms/simulation/sidb/operational_domain.hpp # test/algorithms/simulation/sidb/operational_domain.cpp

… scripts and added total runtime tracking

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 74. Check the log or trigger a new build to see more.

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

experiments/quickcell/quickcell_3_input.cpp

include/fiction/algorithms/iter/bdl_input_iterator.hpp

include/fiction/algorithms/physical_design/design_sidb_gates.hpp

marcelwa · 2024-09-05T14:52:19Z

@Drewniok can you please mark all conversations as resolved that are not applicable or are actually resolved?

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 74. Check the log or trigger a new build to see more.

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

experiments/quickcell/quickcell_3_input.cpp

include/fiction/algorithms/iter/bdl_input_iterator.hpp

include/fiction/algorithms/physical_design/design_sidb_gates.hpp

# Conflicts: # bindings/pyfiction/include/pyfiction/algorithms/iter/bdl_input_iterator.hpp # bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/critical_temperature.hpp # bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/is_operational.hpp # bindings/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp # bindings/pyfiction/test/algorithms/simulation/sidb/test_displacement_robustness_domain.py # include/fiction/algorithms/iter/bdl_input_iterator.hpp # include/fiction/algorithms/simulation/sidb/critical_temperature.hpp # include/fiction/algorithms/simulation/sidb/is_operational.hpp # include/fiction/technology/is_sidb_gate_design_impossible.hpp # test/algorithms/simulation/sidb/displacement_robustness_domain.cpp # test/utils/blueprints/layout_blueprints.hpp

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 57. Check the log or trigger a new build to see more.

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

experiments/quickcell/quickcell_3_input.cpp

github-actions · 2024-09-09T13:31:36Z

include/fiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

+ * @tparam CellType Cell type.
+ */
+template <typename CellType>
+struct bdl_wire


warning: class 'bdl_wire' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [cppcoreguidelines-special-member-functions]

struct bdl_wire ^

include/fiction/algorithms/simulation/sidb/is_operational.hpp

include/fiction/technology/charge_distribution_surface.hpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 57. Check the log or trigger a new build to see more.

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

experiments/quickcell/quickcell_3_input.cpp

include/fiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

include/fiction/algorithms/simulation/sidb/is_operational.hpp

include/fiction/technology/charge_distribution_surface.hpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 37. Check the log or trigger a new build to see more.

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

experiments/quickcell/quickcell_vs_automatic_exhaustive_2_input.cpp

include/fiction/algorithms/iter/bdl_input_iterator.hpp

include/fiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

test/algorithms/simulation/sidb/detect_bdl_wires.cpp

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

github-actions · 2024-09-16T09:16:24Z

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

+#include <pybind11/stl.h>
+
+#include <vector>
+


warning: included header vector is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2024-09-16T09:16:24Z

include/fiction/algorithms/simulation/sidb/detect_bdl_wires.hpp

+     * Destructor for bdl_wire.
+     *
+     */
+    ~bdl_wire() noexcept {}


warning: use '= default' to define a trivial destructor [hicpp-use-equals-default]

Suggested change

~bdl_wire() noexcept {}

~bdl_wire() noexcept = default;

github-actions · 2024-09-16T09:16:24Z

test/algorithms/iter/bdl_input_iterator.cpp

 #include <fiction/algorithms/iter/bdl_input_iterator.hpp>
+#include <fiction/algorithms/simulation/sidb/detect_bdl_wires.hpp>
+#include <fiction/layouts/coordinates.hpp>
 #include <fiction/technology/cell_technologies.hpp>


warning: included header coordinates.hpp is not used directly [misc-include-cleaner]

Suggested change

#include <fiction/technology/cell_technologies.hpp>

#include <fiction/technology/cell_technologies.hpp>

github-actions · 2024-09-16T09:16:24Z

test/algorithms/simulation/sidb/is_operational.cpp

@@ -25,12 +27,23 @@ TEST_CASE("SiQAD OR gate", "[is-operational]")

    const sidb_100_cell_clk_lyt_siqad lat{layout_or_gate};

-    CHECK(is_operational(lat, std::vector<tt>{create_or_tt()},
-                         is_operational_params{sidb_simulation_parameters{2, -0.30}})
+    CHECK(is_operational(


warning: no header providing "CHECK" is directly included [misc-include-cleaner]

CHECK(is_operational( ^

github-actions · 2024-09-16T09:16:24Z

test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp

 #include <fiction/types.hpp>

 #include <cstdint>

 using namespace fiction;

-TEST_CASE("Random cube::coord_t layout generation", "[generate-random-sidb-layout]")
+TEST_CASE("Random cube::coord_t layout generation", "[random-sidb-layout-generator]")


warning: no header providing "TEST_CASE" is directly included [misc-include-cleaner]

test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp:5:

+ #include "catch2/catch_test_macros.hpp"

github-actions · 2024-09-16T09:16:25Z

test/utils/math_utils.cpp

@@ -53,7 +54,7 @@
 }

 TEMPLATE_TEST_CASE("integral_abs should compute the absolute value of a number of different integral types",
-                   "[integral_abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)
+                   "[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)


warning: no header providing "int8_t" is directly included [misc-include-cleaner]

test/utils/math_utils.cpp:9:

- #include <string> + #include <cstdint> + #include <string>

github-actions · 2024-09-16T09:16:25Z

test/utils/math_utils.cpp

@@ -53,7 +54,7 @@
 }

 TEMPLATE_TEST_CASE("integral_abs should compute the absolute value of a number of different integral types",
-                   "[integral_abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)
+                   "[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)


warning: no header providing "uint16_t" is directly included [misc-include-cleaner]

"[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t) ^

github-actions · 2024-09-16T09:16:25Z

test/utils/math_utils.cpp

@@ -53,7 +54,7 @@
 }

 TEMPLATE_TEST_CASE("integral_abs should compute the absolute value of a number of different integral types",
-                   "[integral_abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)
+                   "[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)


warning: no header providing "uint32_t" is directly included [misc-include-cleaner]

"[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t) ^

github-actions · 2024-09-16T09:16:25Z

test/utils/math_utils.cpp

@@ -53,7 +54,7 @@
 }

 TEMPLATE_TEST_CASE("integral_abs should compute the absolute value of a number of different integral types",
-                   "[integral_abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)
+                   "[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)


warning: no header providing "uint64_t" is directly included [misc-include-cleaner]

"[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t) ^

github-actions · 2024-09-16T09:16:25Z

test/utils/math_utils.cpp

@@ -53,7 +54,7 @@
 }

 TEMPLATE_TEST_CASE("integral_abs should compute the absolute value of a number of different integral types",
-                   "[integral_abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)
+                   "[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t)


warning: no header providing "uint8_t" is directly included [misc-include-cleaner]

"[integral-abs]", int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, uint32_t, uint64_t) ^

Drewniok self-assigned this Jul 22, 2024

Drewniok added the enhancement New feature or request label Jul 22, 2024

Drewniok changed the title ~~✨ Quickcell: An Algorithm for Automatic Standard Cell Design~~ ✨ QuickCell: An Algorithm for Automatic Standard Cell Design Jul 22, 2024

pre-commit-ci bot and others added 9 commits July 22, 2024 09:13

🎨 Incorporated pre-commit fixes

0d65ac5

✅ small change to reduce runtime.

7999207

🎨 avoid multi-threading issue if empty

ff0ecda

🎨 reuse input wire information.

f3113e5

📝 Update pyfiction docstrings

1dfc716

Signed-off-by: GitHub Actions <[email protected]>

🎨 add const.

5178223

🎨 Incorporated pre-commit fixes

5e1ac21

🎨 small fixes.

78f1857

🎨 Incorporated pre-commit fixes

4fbb7e0

Drewniok and others added 17 commits July 22, 2024 18:40

🐛 fix out-of-range issue.

b30945e

📝 Update pyfiction docstrings

5b27a93

Signed-off-by: GitHub Actions <[email protected]>

🔀 solve merge conflict.

a07e956

🎨 Incorporated pre-commit fixes

9e0454a

🎨 small fix.

aa279ae

Merge remote-tracking branch 'origin/quickcell' into quickcell

b3e473e

🎨 fix floating-point issue.

817fe87

🎨 Incorporated pre-commit fixes

9011088

🎨 fix floating-point issue.

a356a9d

🎨 fix floating-point issue.

389b7e1

⚗️ Added 3D versions of the operational domain computation experiment…

9cef201

… scripts and added total runtime tracking

📝 Update pyfiction docstrings

4fa155b

Signed-off-by: GitHub Actions <[email protected]>

🚚 add skeleton files.

51e86ef

⚗️ add experiment script for 3-input gates.

34d2cdb

⚗️ add experiment script for 3-input gates.

9670a58

🩹 small fix.

4bc5f9a

Merge branch 'main' into quickcell

98f97fd

github-actions bot reviewed Sep 3, 2024

View reviewed changes

Drewniok and others added 2 commits September 6, 2024 12:21

🎨 small fix.

80b609c

🎨 Incorporated pre-commit fixes

e37f4dc

github-actions bot reviewed Sep 6, 2024

View reviewed changes

Drewniok and others added 10 commits September 8, 2024 16:54

🔀 solve merge conflicts.

899c872

🎨 Incorporated pre-commit fixes

f2c243d

📝 Update pyfiction docstrings

d3f3b2f

Signed-off-by: GitHub Actions <[email protected]>

🐍 fix bindings after merge.

20c320f

🎨 Incorporated pre-commit fixes

e0ae7d2

🐍 small fix.

7086e80

🎨 small fix.

ef33275

🎨 Incorporated pre-commit fixes

7112d37

⚗️ small fix.

d944b22

github-actions bot reviewed Sep 9, 2024

View reviewed changes

Drewniok and others added 3 commits September 10, 2024 09:43

🚨 fix clang-tidy warnings.

c78d205

🎨 Incorporated pre-commit fixes

deebf85

🚨 fix clang-tidy.

2a435a7

github-actions bot reviewed Sep 13, 2024

View reviewed changes

Drewniok and others added 7 commits September 16, 2024 09:02

🎨 small fixes.

0500a1f

🎨 Incorporated pre-commit fixes

ed8f109

📝 Update pyfiction docstrings

b767450

Signed-off-by: GitHub Actions <[email protected]>

🚨 fix clang-tidy.

24a12e3

Merge branch 'main' into quickcell

ff58ff1

🎨 Incorporated pre-commit fixes

c2bde93

🚨 fix clang-tidy.

307fd37

github-actions bot reviewed Sep 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ QuickCell: An Algorithm for Automatic Standard Cell Design #481

✨ QuickCell: An Algorithm for Automatic Standard Cell Design #481

Drewniok commented Jul 22, 2024

codecov bot commented Jul 22, 2024 •

edited

Loading

github-actions bot left a comment

marcelwa commented Sep 5, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Sep 9, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

github-actions bot Sep 16, 2024

	#include <fiction/technology/cell_technologies.hpp>
	#include <fiction/technology/cell_technologies.hpp>

✨ QuickCell: An Algorithm for Automatic Standard Cell Design #481

Are you sure you want to change the base?

✨ QuickCell: An Algorithm for Automatic Standard Cell Design #481

Conversation

Drewniok commented Jul 22, 2024

Description

Checklist:

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

marcelwa commented Sep 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 9, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

codecov bot commented Jul 22, 2024 •

edited

Loading