Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Added Python Setup to CI Workflow #490

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Aug 2, 2024

Description

This PR updates the Windows and MacOS CI workflow to include Python 3.10 and pip caching. This change is required due to pybind's removal (pybind/pybind11@7233072) of support for Python versions earlier than 3.8.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok self-assigned this Aug 2, 2024
@Drewniok Drewniok added the github_actions Pull requests that update GitHub Actions code label Aug 2, 2024
@Drewniok Drewniok changed the title 💚 Added Python Setup to Windows CI Workflow 💚 Added Python Setup to CI Workflow Aug 2, 2024
@Drewniok Drewniok requested a review from marcelwa August 2, 2024 13:30
marcelwa
marcelwa previously approved these changes Aug 2, 2024
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@marcelwa
Copy link
Collaborator

marcelwa commented Aug 3, 2024

@Drewniok why was the pip caching removed?

@Drewniok
Copy link
Collaborator Author

Drewniok commented Aug 5, 2024

@marcelwa The windows CI started to fail again. If we need pip caching, I can try to fix it.

@Drewniok Drewniok merged commit 10ce953 into cda-tum:main Aug 5, 2024
11 checks passed
@Drewniok Drewniok deleted the update_python_version branch August 5, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants