Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Extended Time-to-Solution Function #500

Merged
merged 38 commits into from
Aug 21, 2024

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Aug 15, 2024

Description

This PR extends the time-to-solution (tts) calculation with a new function that can be used when simulation results are already available and we want to determine the tts based on those results.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Aug 15, 2024
@Drewniok Drewniok self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 95.26627% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.14%. Comparing base (b213292) to head (d5c8a20).
Report is 3 commits behind head on main.

Files Patch % Lines
...st/algorithms/simulation/sidb/time_to_solution.cpp 85.71% 7 Missing ⚠️
...ion/algorithms/simulation/sidb/is_ground_state.hpp 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   98.15%   98.14%   -0.01%     
==========================================
  Files         224      224              
  Lines       31045    31133      +88     
  Branches     1549     1561      +12     
==========================================
+ Hits        30471    30557      +86     
- Misses        574      576       +2     
Files Coverage Δ
.../fiction/algorithms/simulation/sidb/quickexact.hpp 98.78% <ø> (+<0.01%) ⬆️
...orithms/simulation/sidb/sidb_simulation_result.hpp 100.00% <ø> (ø)
...on/algorithms/simulation/sidb/time_to_solution.hpp 100.00% <100.00%> (+2.70%) ⬆️
...fiction/technology/charge_distribution_surface.hpp 99.36% <100.00%> (+<0.01%) ⬆️
...ermine_the_groundstate_from_simulation_results.cpp 100.00% <100.00%> (ø)
...est/algorithms/simulation/sidb/is_ground_state.cpp 100.00% <100.00%> (ø)
test/technology/charge_distribution_surface.cpp 100.00% <100.00%> (ø)
...ion/algorithms/simulation/sidb/is_ground_state.hpp 93.75% <92.85%> (-6.25%) ⬇️
...st/algorithms/simulation/sidb/time_to_solution.cpp 92.07% <85.71%> (-2.52%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d884da...d5c8a20. Read the comment docs.

@Drewniok Drewniok changed the title ✨ Extend Time-to-Solution Function ✨ Extended Time-to-Solution Function Aug 15, 2024
@Drewniok Drewniok requested a review from marcelwa August 16, 2024 10:28
@Drewniok Drewniok requested a review from marcelwa August 16, 2024 14:16
@Drewniok Drewniok requested a review from marcelwa August 21, 2024 10:34
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
Copy link
Collaborator

pre-commit.ci is now failing. Please run clang-format locally and recommit

@Drewniok
Copy link
Collaborator Author

pre-commit.ci is now failing. Please run clang-format locally and recommit

This happens occasionally.

@marcelwa
Copy link
Collaborator

pre-commit.ci is now failing. Please run clang-format locally and recommit

This happens occasionally.

The log gives information on why. In this case, it seems that clang-format was trying to upload files it modified but couldn't. Maybe that's a permission issue on branches again. What do you think?

@Drewniok
Copy link
Collaborator Author

pre-commit.ci is now failing. Please run clang-format locally and recommit

This happens occasionally.

The log gives information on why. In this case, it seems that clang-format was trying to upload files it modified but couldn't. Maybe that's a permission issue on branches again. What do you think?

That's one possible explanation! Thanks!

@marcelwa marcelwa merged commit 8cbe5bc into cda-tum:main Aug 21, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants