Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 clang-tidy warnings #507

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

simon1hofmann
Copy link
Collaborator

Description

Applied clang-tidy suggestions`.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

marcelwa
marcelwa previously approved these changes Aug 22, 2024
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! 🙏

@simon1hofmann simon1hofmann self-assigned this Aug 22, 2024
@simon1hofmann simon1hofmann added the small fix Non-critical issue or inconsistency label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (64fb20b) to head (6b907ed).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   98.14%   98.15%           
=======================================
  Files         224      224           
  Lines       31130    31128    -2     
  Branches     1560     1561    +1     
=======================================
- Hits        30554    30553    -1     
+ Misses        576      575    -1     
Files Coverage Δ
...s/physical_design/graph_oriented_layout_design.hpp 100.00% <100.00%> (ø)
.../fiction/algorithms/physical_design/orthogonal.hpp 96.36% <ø> (ø)
...s/physical_design/graph_oriented_layout_design.cpp 100.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab74363...6b907ed. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit b03282c into cda-tum:main Aug 22, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants