⚗️ Added a runtime script for three state simulation and apply small changes. #520

Drewniok · 2024-09-03T08:59:11Z

Description

This PR adds an experiment script to compare 3-state simulation runtimes between QuickExact and ExGS.
It also introduces a small change to simplify the random generation of SiDB layouts.

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have added a changelog entry.
I have created/adjusted the Python bindings for any new or updated functionality.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: GitHub Actions <[email protected]>

…ation' into experiment_for_three_state_simulation

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp

codecov · 2024-09-03T11:51:47Z

Codecov Report

Attention: Patch coverage is 96.92308% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.18%. Comparing base (2957b0c) to head (b3c057a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/simulation/sidb/random_sidb_layout_generator.hpp	81.81%	2 Missing ⚠️
include/fiction/utils/layout_utils.hpp	94.87%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   98.17%   98.18%           
=======================================
  Files         224      224           
  Lines       31600    31634   +34     
  Branches     1575     1574    -1     
=======================================
+ Hits        31023    31059   +36     
+ Misses        577      575    -2

Files with missing lines	Coverage Δ
...n/algorithms/physical_design/design_sidb_gates.hpp	`98.18% <100.00%> (-0.05%)`	⬇️
...lgorithms/simulation/sidb/critical_temperature.hpp	`97.29% <100.00%> (ø)`
...fiction/technology/charge_distribution_surface.hpp	`99.36% <100.00%> (-0.01%)`	⬇️
include/fiction/technology/fcn_gate_library.hpp	`88.09% <ø> (ø)`
...t/algorithms/physical_design/design_sidb_gates.cpp	`100.00% <100.00%> (ø)`
...s/simulation/sidb/random_sidb_layout_generator.cpp	`94.04% <100.00%> (-0.33%)`	⬇️
test/utils/layout_utils.cpp	`100.00% <100.00%> (ø)`
...s/simulation/sidb/random_sidb_layout_generator.hpp	`91.89% <81.81%> (-3.67%)`	⬇️
include/fiction/utils/layout_utils.hpp	`98.31% <94.87%> (-0.68%)`	⬇️

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2957b0c...b3c057a. Read the comment docs.

…ation' into experiment_for_three_state_simulation

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/utils/layout_utils.hpp

test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

include/fiction/technology/charge_distribution_surface.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

...ulation/electrostatic_ground_state/runtime_analysis_layouts_with_possible_positive_sidbs.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

test/algorithms/physical_design/design_sidb_gates.cpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

...ulation/electrostatic_ground_state/runtime_analysis_layouts_with_possible_positive_sidbs.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

test/algorithms/physical_design/design_sidb_gates.cpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/utils/layout_utils.hpp

test/algorithms/physical_design/design_sidb_gates.cpp

marcelwa · 2024-09-10T09:45:36Z

@Drewniok please remember to mark every conversation as resolved that you have already addressed.

...ings/pyfiction/include/pyfiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/algorithms/physical_design/design_sidb_gates.hpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

include/fiction/technology/charge_distribution_surface.hpp

include/fiction/utils/layout_utils.hpp

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

test/algorithms/physical_design/design_sidb_gates.cpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

test/algorithms/physical_design/design_sidb_gates.cpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

test/algorithms/physical_design/design_sidb_gates.cpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

Drewniok and others added 7 commits September 3, 2024 08:59

🎨 make it easier to create layouts with positive sides.

facb9c5

⚗️ add experiment script.

7ebdfcc

📝 Update pyfiction docstrings

5a937d4

Signed-off-by: GitHub Actions <[email protected]>

🎨 small changes.

c8f4968

Merge remote-tracking branch 'origin/experiment_for_three_state_simul…

04cbaa5

…ation' into experiment_for_three_state_simulation

📝 Update pyfiction docstrings

bb723eb

Signed-off-by: GitHub Actions <[email protected]>

🎨 Incorporated pre-commit fixes

2faea27

Drewniok changed the title ~~⚗️ Added a runtime script for three state simulation and smaller changes.~~ ⚗️ Added a runtime script for three state simulation and apply small changes. Sep 3, 2024

github-actions bot reviewed Sep 3, 2024

View reviewed changes

Drewniok self-assigned this Sep 3, 2024

Drewniok and others added 7 commits September 3, 2024 16:39

🚨 implement clang-tidy warnings.

a03a196

Merge branch 'main' into experiment_for_three_state_simulation

f000244

🎨 Incorporated pre-commit fixes

1fface6

🎨 small fix.

01bae3a

Merge remote-tracking branch 'origin/experiment_for_three_state_simul…

993a545

…ation' into experiment_for_three_state_simulation

📝 Update pyfiction docstrings

a2f897e

Signed-off-by: GitHub Actions <[email protected]>

🎨 Incorporated pre-commit fixes

bd5ca78

github-actions bot reviewed Sep 3, 2024

View reviewed changes

Drewniok added 2 commits September 4, 2024 07:43

🎨 small fix to avoid window compile issue.

81d1dbd

🎨 small fix.

17a7330

Drewniok commented Sep 4, 2024

View reviewed changes

include/fiction/technology/charge_distribution_surface.hpp Show resolved Hide resolved

🎨 small fix.

73e29df

Drewniok requested a review from marcelwa September 4, 2024 06:16

github-actions bot reviewed Sep 4, 2024

View reviewed changes

🎨 small fix.

415c9ea

github-actions bot reviewed Sep 5, 2024

View reviewed changes

Merge branch 'main' into experiment_for_three_state_simulation

f53d3de

Drewniok and others added 2 commits September 9, 2024 13:07

🐍 small fix.

2ef53e6

🎨 Incorporated pre-commit fixes

7aedb4d

github-actions bot reviewed Sep 9, 2024

View reviewed changes

Drewniok and others added 2 commits September 9, 2024 13:46

🎨 small fix in the experiment script.

d6d1cd8

🎨 Incorporated pre-commit fixes

b4db8b2

github-actions bot reviewed Sep 9, 2024

View reviewed changes

✅ add more test cases and small fixes.

6c78be9

github-actions bot reviewed Sep 9, 2024

View reviewed changes

marcelwa requested changes Sep 10, 2024

View reviewed changes

Drewniok and others added 3 commits September 12, 2024 08:45

🎨 implement Marcels feedback.

8aa6f50

🎨 Incorporated pre-commit fixes

095cf53

📝 Update pyfiction docstrings

427c5c0

Signed-off-by: GitHub Actions <[email protected]>

github-actions bot reviewed Sep 12, 2024

View reviewed changes

📝 small fix.

eac49ae

github-actions bot reviewed Sep 12, 2024

View reviewed changes

Drewniok added 2 commits September 13, 2024 11:21

🎨 small fix.

cbccaa8

Merge branch 'main' into experiment_for_three_state_simulation

198412c

github-actions bot reviewed Sep 13, 2024

View reviewed changes

Drewniok and others added 2 commits September 13, 2024 15:41

🎨 small update.

9f4f7ef

🎨 Incorporated pre-commit fixes

7143f0a

github-actions bot reviewed Sep 13, 2024

View reviewed changes

Merge branch 'main' into experiment_for_three_state_simulation

2b0f53f

Drewniok requested a review from marcelwa September 16, 2024 07:56

Drewniok added the enhancement New feature or request label Sep 16, 2024

✅ add additional test.

b3c057a

github-actions bot reviewed Sep 16, 2024

View reviewed changes

marcelwa approved these changes Sep 16, 2024

View reviewed changes

github-actions bot reviewed Sep 16, 2024

View reviewed changes

Drewniok merged commit a2971b4 into cda-tum:main Sep 16, 2024
61 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚗️ Added a runtime script for three state simulation and apply small changes. #520

⚗️ Added a runtime script for three state simulation and apply small changes. #520

Drewniok commented Sep 3, 2024

github-actions bot left a comment

codecov bot commented Sep 3, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

marcelwa commented Sep 10, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

⚗️ Added a runtime script for three state simulation and apply small changes. #520

⚗️ Added a runtime script for three state simulation and apply small changes. #520

Conversation

Drewniok commented Sep 3, 2024

Description

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 3, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

marcelwa commented Sep 10, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 3, 2024 •

edited

Loading