Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Set up a consistent clang-tidy workflow together with a designated CI code review process #64

Merged
merged 15 commits into from
Oct 21, 2022

Conversation

marcelwa
Copy link
Collaborator

This project-wide clang-tidy configuration will ensure both a consistent coding style and encourage the use of C++ best practices. Many thanks to @burgholzer for the recommendation!

@marcelwa marcelwa added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Oct 21, 2022
@marcelwa marcelwa self-assigned this Oct 21, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 47. Check the log or trigger a new build to see more.

cli/cmd/io/fqca.hpp Show resolved Hide resolved
cli/cmd/io/qca.hpp Show resolved Hide resolved
cli/cmd/io/qcc.hpp Show resolved Hide resolved
cli/cmd/io/qll.hpp Show resolved Hide resolved
cli/cmd/io/sqd.hpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #64 (2c48908) into main (7d3d814) will increase coverage by 0.02%.
The diff coverage is 93.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   93.08%   93.11%   +0.02%     
==========================================
  Files          45       45              
  Lines        5163     5184      +21     
==========================================
+ Hits         4806     4827      +21     
  Misses        357      357              
Impacted Files Coverage Δ
include/fiction/io/tt_reader.hpp 94.44% <ø> (ø)
include/fiction/io/write_qca_layout.hpp 83.88% <0.00%> (ø)
include/fiction/layouts/bounding_box.hpp 100.00% <ø> (ø)
include/fiction/layouts/cartesian_layout.hpp 97.75% <ø> (ø)
include/fiction/layouts/hexagonal_layout.hpp 98.50% <ø> (ø)
include/fiction/technology/cell_technologies.hpp 100.00% <ø> (ø)
include/fiction/utils/range.hpp 100.00% <ø> (ø)
include/fiction/io/network_reader.hpp 65.21% <55.55%> (ø)
include/fiction/utils/placement_utils.hpp 85.05% <66.66%> (ø)
include/fiction/technology/qca_one_library.hpp 88.52% <75.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c622dd...2c48908. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa enabled auto-merge (squash) October 21, 2022 17:54
@marcelwa marcelwa merged commit 8b66c81 into main Oct 21, 2022
@marcelwa marcelwa deleted the clang-tidy branch October 21, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant