Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed a bug with layout DOT drawers and a small inconsistency in the tests #66

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

marcelwa
Copy link
Collaborator

  • write_dot_layout called the wrong DOT drawer
  • technology_network was not sufficiently checked for function creation traits

@marcelwa marcelwa self-assigned this Oct 27, 2022
@marcelwa marcelwa added the bug Something isn't working label Oct 27, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #66 (aaec291) into main (7d3d814) will increase coverage by 0.00%.
The diff coverage is 92.97%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   93.08%   93.09%           
=======================================
  Files          45       45           
  Lines        5163     5184   +21     
=======================================
+ Hits         4806     4826   +20     
- Misses        357      358    +1     
Impacted Files Coverage Δ
include/fiction/io/tt_reader.hpp 94.44% <ø> (ø)
include/fiction/io/write_qca_layout.hpp 83.88% <0.00%> (ø)
include/fiction/layouts/bounding_box.hpp 100.00% <ø> (ø)
include/fiction/layouts/cartesian_layout.hpp 97.75% <ø> (ø)
include/fiction/layouts/hexagonal_layout.hpp 98.50% <ø> (ø)
include/fiction/technology/cell_technologies.hpp 100.00% <ø> (ø)
include/fiction/utils/range.hpp 100.00% <ø> (ø)
include/fiction/io/network_reader.hpp 65.21% <55.55%> (ø)
include/fiction/utils/placement_utils.hpp 85.05% <66.66%> (ø)
include/fiction/technology/qca_one_library.hpp 88.52% <75.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c1301...aaec291. Read the comment docs.

@marcelwa marcelwa merged commit 7c17826 into main Oct 27, 2022
@marcelwa marcelwa deleted the bugfix branch October 27, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant