Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded value #43

Open
MariaEmmerich opened this issue Sep 4, 2024 · 0 comments · May be fixed by #50
Open

Hardcoded value #43

MariaEmmerich opened this issue Sep 4, 2024 · 0 comments · May be fixed by #50
Assignees
@MariaEmmerich
Labels
bug Something isn't working fix Fix for something that is not working

Comments

@MariaEmmerich
Copy link
Collaborator

The resolution for the calculation of the analytical solution for diffusive mixing is hardcoded.

-> MixingModels.hh line 450
@micheltakken micheltakken added bug Something isn't working fix Fix for something that is not working labels Sep 5, 2024
MariaEmmerich added a commit that referenced this issue Sep 6, 2024
@MariaEmmerich
Rename resolution to numFourierTerms
2abcf70 
The resolution for the calculation of diffusion using an analytical solution including a fourier series is renamed to numFourierTerms and set as a private variable in the DiffusionMixingModel.
It is set to ```int numFourierTerms = 100;```
It can be adapted using ```resetNumFourierTerms(int newNumFourierTerms)```

This solves Issue #43
@MariaEmmerich MariaEmmerich linked a pull request Sep 6, 2024 that will close this issue
Diffusive Mixing (1D <--> CFD) #50
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariaEmmerich MariaEmmerich

Labels
bug Something isn't working fix Fix for something that is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diffusive Mixing (1D <--> CFD) cda-tum/mmft-simulator
2 participants
@micheltakken @MariaEmmerich