-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments to handling of hook errors in FT state preparation circuit synthesis #285
Open
pehamTom
wants to merge
21
commits into
main
Choose a base branch
from
topological-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+510
−452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehamTom
added
bug
Something isn't working
enhancement
Enhancement to existing feature
feature
New feature or request
labels
Sep 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 49 49
Lines 4153 4151 -2
Branches 372 372
=======================================
- Hits 3471 3468 -3
- Misses 682 683 +1
*This pull request uses carry forward flags. Click here to find out more.
|
burgholzer
added
fix
Fix for something that isn't working
and removed
bug
Something isn't working
labels
Sep 17, 2024
With the new strict fault-tolerance requirement, the tetrahedral code is not as easy to assess anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement to existing feature
feature
New feature or request
fix
Fix for something that isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is a bug in the handling of hook errors where they are not computed quite correctly. Unfortunately, this didn't come up in previous simulations and was therefore missed.
In the process of fixing this and resynthesizing the current circuits, I realized that sometimes, flagging the first verification layer leads to better overall results than handling hook errors in the second verification layer. Therefore, this PR introduces an option in the state preparation synthesis that chooses whether the first layer should be hooked or not.
Checklist: