Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to handling of hook errors in FT state preparation circuit synthesis #285

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Sep 17, 2024

Description

Currently, there is a bug in the handling of hook errors where they are not computed quite correctly. Unfortunately, this didn't come up in previous simulations and was therefore missed.

In the process of fixing this and resynthesizing the current circuits, I realized that sometimes, flagging the first verification layer leads to better overall results than handling hook errors in the second verification layer. Therefore, this PR introduces an option in the state preparation synthesis that chooses whether the first layer should be hooked or not.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@pehamTom pehamTom added bug Something isn't working enhancement Enhancement to existing feature feature New feature or request labels Sep 17, 2024
@pehamTom pehamTom self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.5%. Comparing base (9995a01) to head (072be86).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/mqt/qecc/ft_stateprep/state_prep.py 90.9% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #285     +/-   ##
=======================================
- Coverage   83.5%   83.5%   -0.1%     
=======================================
  Files         49      49             
  Lines       4153    4151      -2     
  Branches     372     372             
=======================================
- Hits        3471    3468      -3     
- Misses       682     683      +1     
Flag Coverage Δ *Carryforward flag
cpp 83.6% <ø> (ø) Carriedforward from b024e0e
python 83.4% <90.9%> (-0.1%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/ft_stateprep/state_prep.py 71.7% <90.9%> (-0.2%) ⬇️

@burgholzer burgholzer added fix Fix for something that isn't working and removed bug Something isn't working labels Sep 17, 2024
@pehamTom pehamTom marked this pull request as ready for review September 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature feature New feature or request fix Fix for something that isn't working
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants