chore: notice for https://github.com/aws/aws-cdk/issues/25674 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
commented
May 23, 2023
| "title": "(eks) eks overly permissive trust policies", | ||
| "issueNumber": 25674, | ||
| "overview": "The default MastersRole allows any identity in the account with the appropriate sts:AssumeRole permissions to assume it.", | ||
| "components": [ |
There was a problem hiding this comment.
These only suffer from the default masters role.
iliapolo
commented
May 23, 2023
| "title": "(eks) eks overly permissive trust policies", | ||
| "issueNumber": 25674, | ||
| "overview": "Cluster CreationRole and default MastersRole allows any identity in the account with the appropriate sts:AssumeRole permissions to assume it.", | ||
| "components": [ |
There was a problem hiding this comment.
These suffer from both the default masters role and the creation role
iliapolo
commented
May 23, 2023
| for (const component of notice.components) { | ||
| if (component.version === '1.*') { continue; } // Special range that we allow | ||
| if (semver.intersects(component.version, '2') && !semver.subset(component.version, '2')) { |
There was a problem hiding this comment.
Using 2 as the range wouldn't allow pre releases, and we still have customers using those...
There was a problem hiding this comment.
> semver.satisfies('2.0.0-rc.2', '>=2.0.0-rc.1 <2.80.0')
true
> semver.satisfies('2.0.0-rc.2', '^2.0.0 <2.80.0')
false
There was a problem hiding this comment.
I think what we're trying to convey here is that:
- A range may not cross a major version boundary (if we use
>=we must also have a<) - A range must be bounded at the top (if we use
^we must also have a<)
Maybe it would be simpler to do the following:
- Do a linear scan of version ranges
x ∈ [1..10], testx.0.0andx.10000.0and make sure not more than onexis within the range - Of that same
x, testx.10000.0and test that it is not matched.
Potentially a simpler set of tests?
There was a problem hiding this comment.
Potentially, I honestly don't have the mental capacity right now to rework this...
iliapolo
commented
May 23, 2023
Co-authored-by: Rico Hermans <[email protected]>
rix0rrr
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are two separate problems, introduced in two separate commits, issue two notices based on the affeceted versions. Note that we have no way of knowing if customers are actually impacted by the default masters role because we don't know if they pass the
mastersRoleproperty or not.