chore: bound the parallelism #162
Merged
+152
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the linter rule that checks for bounded parallelism, and mark the 2 locations that do `Promise.all` as bounded.
mrgrain
reviewed
Nov 5, 2024
| @@ -119,7 +120,11 @@ export class AssetPublishing implements IPublishProgress { | |||
| */ | |||
| public async publish(options: PublishOptions = {}): Promise<void> { | |||
| if (this.publishInParallel) { | |||
| await Promise.all(this.assets.map(async (asset) => this.publishAsset(asset, options))); | |||
| const limit = pLimit(20); | |||
There was a problem hiding this comment.
Do we need/want to be this restrictive?
mrgrain
requested changes
Nov 5, 2024
|
Should have been a chore, thanks |
mrgrain
approved these changes
Nov 5, 2024
aws-cdk-automation
pushed a commit
that referenced
this pull request
Nov 6, 2024
Add the linter rule that checks for bounded parallelism, and mark the 2 locations that do `Promise.all` as bounded. (cherry picked from commit b6fbdbe) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # test/files.test.ts
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
# Backport This will backport the following commits from `main` to `v2-main`: - [chore: bound the parallelism (#162)](#162) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: Rico Hermans <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the linter rule that checks for bounded parallelism, and mark the 2 locations that do
Promise.allas bounded.