Skip to content

Commit

Permalink
fix(prune-handler): upgrade to SDK v3 (#1466)
Browse files Browse the repository at this point in the history
Upgrade prune-handler and prune-queue-handler to AWS SDK v3. These are
the last functions that used AWS SDK v2, so the dependency on v2 has
also been removed.

In the prune handler, there is a piece of code that is executed inside a
for loop that iterates on the deny list. It calls an "on-change"
handler, which, turns out to be the catalog builder. But there is no
need to call this function repeatedly. Only once after all the deny list
has been processed. So I moved it outside the for loop.

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
  • Loading branch information
otaviomacedo authored Sep 17, 2024
1 parent fc61b36 commit 410e229
Show file tree
Hide file tree
Showing 18 changed files with 478 additions and 356 deletions.
8 changes: 0 additions & 8 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ const project = new CdklabsConstructLibrary({
'aws-embedded-metrics',
'aws-sdk-client-mock',
'aws-sdk-client-mock-jest',
'aws-sdk-mock',
'aws-sdk',
'aws-xray-sdk-core',
'case',
'cdk-dia',
Expand Down
2 changes: 0 additions & 2 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 410e229

Please sign in to comment.