fix: test if Notify Slack log message JSON is valid #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `notify-slack` lambda function to check if the parsed JSON is actually a JSON object.
wmoussa-gc
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Sorry for commenting, I worked on that file.
Good catch! I'd suggest removing the comment on line 123, as it's now misleading. This isn't solely related to the forms app anymore, and the error, wherever it occurs, isn't necessarily unhandled, in my opinion.
There was a problem hiding this comment.
Makes sense! I've updated the comment to be more generic.
bryan-robitaille
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the
notify-slacklambda function to check if the parsed JSON is actually a JSON object.This will eliminate the Slack messages we see where the expected log message format cannot be parsed:
Related