chore: GCForms release v3.23.1 #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sre-read-write[bot]](https://avatars.githubusercontent.com/in/146819?s=60&v=4){kind=small}
sre-read-write
bot
requested a review
from bryan-robitaille
as a code owner
sre-read-write
bot
requested review from
dsamojlenko,
timarney and
craigzour
as code owners
sre-read-write
bot
force-pushed
the
release-please--branches--develop
branch
9 times, most recently
from
d4d469f
to
ec34c0b
Compare
sre-read-write
bot
force-pushed
the
release-please--branches--develop
branch
from
ec34c0b
to
f61920b
Compare
craigzour
approved these changes
Sep 23, 2024
Production: app✅ Terraform Init: Plan: 1 to add, 0 to change, 0 to destroyShow summary
Show planResource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# aws_ecs_task_definition.form_viewer will be created
+ resource "aws_ecs_task_definition" "form_viewer" {
+ arn = (known after apply)
+ arn_without_revision = (known after apply)
+ container_definitions = jsonencode(
[
+ {
+ Command = null
+ Cpu = 0
+ CredentialSpecs = null
+ DependsOn = null
+ DisableNetworking = null
+ DnsSearchDomains = null
+ DnsServers = null
+ DockerLabels = null
+ DockerSecurityOptions = null
+ EntryPoint = null
+ Environment = [
+ {
+ Name = "AUDIT_LOG_QUEUE_URL"
+ Value = "https://sqs.ca-central-1.amazonaws.com/957818836222/audit_log_queue"
},
+ {
+ Name = "COGNITO_CLIENT_ID"
+ Value = "5rkjd3us3ocssieiitdbtjitiv"
},
+ {
+ Name = "COGNITO_ENDPOINT_URL"
+ Value = "cognito-idp.ca-central-1.amazonaws.com/ca-central-1_eSTGTCw33"
},
+ {
+ Name = "EMAIL_ADDRESS_CONTACT_US"
+ Value = "[email protected]"
},
+ {
+ Name = "EMAIL_ADDRESS_SUPPORT"
+ Value = "[email protected]"
},
+ {
+ Name = "HOST_URL"
+ Value = "https://forms-formulaires.alpha.canada.ca"
},
+ {
+ Name = "METRIC_PROVIDER"
+ Value = "stdout"
},
+ {
+ Name = "NEXTAUTH_URL"
+ Value = "https://forms-formulaires.alpha.canada.ca"
},
+ {
+ Name = "RECAPTCHA_V3_SITE_KEY"
+ Value = "6LfuLrQnAAAAAK9Df3gem4XLMRVY2Laq6t2fhZhZ"
},
+ {
+ Name = "REDIS_URL"
+ Value = "gcforms-redis-rep-group.iyrckm.ng.0001.cac1.cache.amazonaws.com"
},
+ {
+ Name = "RELIABILITY_FILE_STORAGE"
+ Value = "forms-production-reliability-file-storage"
},
+ {
+ Name = "REPROCESS_SUBMISSION_QUEUE_URL"
+ Value = "https://sqs.ca-central-1.amazonaws.com/957818836222/reprocess_submission_queue.fifo"
},
+ {
+ Name = "TEMPLATE_ID"
+ Value = "92096ac6-1cc5-40ae-9052-fffdb8439a90"
},
+ {
+ Name = "TEMPORARY_TOKEN_TEMPLATE_ID"
+ Value = "61cec9c4-64ca-4e4d-b4d2-a0e931c44422"
},
+ {
+ Name = "TRACER_PROVIDER"
+ Value = "stdout"
},
+ {
+ Name = "VAULT_FILE_STORAGE"
+ Value = "forms-production-vault-file-storage"
},
+ {
+ Name = "ZITADEL_PROVIDER"
+ Value = "https://auth.forms-formulaires.alpha.canada.ca"
},
]
+ EnvironmentFiles = null
+ Essential = true
+ ExtraHosts = null
+ FirelensConfiguration = null
+ HealthCheck = null
+ Hostname = null
+ Image = "957818836222.dkr.ecr.ca-central-1.amazonaws.com/form_viewer_production"
+ Interactive = null
+ Links = null
+ LinuxParameters = {
+ Capabilities = {
+ Add = []
+ Drop = [
+ "ALL",
]
}
+ Devices = null
+ InitProcessEnabled = null
+ MaxSwap = null
+ SharedMemorySize = null
+ Swappiness = null
+ Tmpfs = null
}
+ LogConfiguration = {
+ LogDriver = "awslogs"
+ Options = {
+ awslogs-group = "Forms"
+ awslogs-region = "ca-central-1"
+ awslogs-stream-prefix = "ecs-form-viewer"
}
+ SecretOptions = null
}
+ Memory = null
+ MemoryReservation = null
+ MountPoints = []
+ Name = "form_viewer"
+ PortMappings = [
+ {
+ AppProtocol = ""
+ ContainerPort = 3000
+ ContainerPortRange = null
+ HostPort = 3000
+ Name = null
+ Protocol = "tcp"
},
]
+ Privileged = null
+ PseudoTerminal = null
+ ReadonlyRootFilesystem = null
+ RepositoryCredentials = null
+ ResourceRequirements = null
+ Secrets = [
+ {
+ Name = "DATABASE_URL"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:server-database-url-jVtWGE"
},
+ {
+ Name = "FRESHDESK_API_KEY"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:freshdesk_api_key-2Q118n"
},
+ {
+ Name = "GC_NOTIFY_CALLBACK_BEARER_TOKEN"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:notify_callback_bearer_token-sWF9yQ"
},
+ {
+ Name = "NOTIFY_API_KEY"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:notify_api_key-sLtddr"
},
+ {
+ Name = "RECAPTCHA_V3_SECRET_KEY"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:recaptcha_secret-LxfCjN"
},
+ {
+ Name = "SENTRY_API_KEY"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:sentry_api_key-zulAvy"
},
+ {
+ Name = "TOKEN_SECRET"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:token_secret-jw4Dou"
},
+ {
+ Name = "ZITADEL_ADMINISTRATION_KEY"
+ ValueFrom = "arn:aws:secretsmanager:ca-central-1:957818836222:secret:zitadel_administration_key-7rE09g"
},
]
+ StartTimeout = null
+ StopTimeout = null
+ SystemControls = []
+ Ulimits = null
+ User = null
+ VolumesFrom = []
+ WorkingDirectory = null
},
]
)
+ cpu = "2048"
+ execution_role_arn = "arn:aws:iam::957818836222:role/form-viewer"
+ family = "form-viewer"
+ id = (known after apply)
+ memory = "4096"
+ network_mode = "awsvpc"
+ requires_compatibilities = [
+ "FARGATE",
]
+ revision = (known after apply)
+ skip_destroy = false
+ tags_all = {
+ "CostCentre" = "forms-platform-production"
+ "Terraform" = "true"
}
+ task_role_arn = "arn:aws:iam::957818836222:role/form-viewer"
+ track_latest = false
}
Plan: 1 to add, 0 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_appautoscaling_target.forms[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.forms"]
WARN - plan.json - main - Missing Common Tags: ["aws_codedeploy_app.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_codedeploy_deployment_group.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_cluster.forms"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_service.form_viewer"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_task_definition.form_viewer"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.cognito"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_dynamodb"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_kms"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_s3"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_secrets_manager"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_sqs"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.codedeploy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.forms"]
34 tests, 19 passed, 15 warnings, 0 failures, 0 exceptions
|
Production: alarms✅ Terraform Init: Plan: 0 to add, 1 to change, 0 to destroyShow summary
Show planResource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_cloudwatch_log_subscription_filter.api_error_detection[0] has moved to aws_cloudwatch_log_subscription_filter.api_error_detection
resource "aws_cloudwatch_log_subscription_filter" "api_error_detection" {
id = "cwlsf-973426895"
name = "error_detection_in_api_logs"
# (5 unchanged attributes hidden)
}
# aws_cloudwatch_log_subscription_filter.idp_error_detection will be updated in-place
# (moved from aws_cloudwatch_log_subscription_filter.idp_error_detection[0])
~ resource "aws_cloudwatch_log_subscription_filter" "idp_error_detection" {
~ filter_pattern = "level=error" -> "[(w1=\"*level=error*\") && w1!=\"*context canceled*\"]"
id = "cwlsf-2763607751"
name = "error_detection_in_idp_logs"
# (4 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.api_cpu_utilization_high_warn[0] has moved to aws_cloudwatch_metric_alarm.api_cpu_utilization_high_warn
resource "aws_cloudwatch_metric_alarm" "api_cpu_utilization_high_warn" {
id = "API-CpuUtilizationWarn"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.api_lb_healthy_host_count[0] has moved to aws_cloudwatch_metric_alarm.api_lb_healthy_host_count
resource "aws_cloudwatch_metric_alarm" "api_lb_healthy_host_count" {
id = "API-HealthyHostCount"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.api_lb_unhealthy_host_count[0] has moved to aws_cloudwatch_metric_alarm.api_lb_unhealthy_host_count
resource "aws_cloudwatch_metric_alarm" "api_lb_unhealthy_host_count" {
id = "API-UnhealthyHostCount"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.api_memory_utilization_high_warn[0] has moved to aws_cloudwatch_metric_alarm.api_memory_utilization_high_warn
resource "aws_cloudwatch_metric_alarm" "api_memory_utilization_high_warn" {
id = "API-MemoryUtilizationWarn"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.api_response_time_warn[0] has moved to aws_cloudwatch_metric_alarm.api_response_time_warn
resource "aws_cloudwatch_metric_alarm" "api_response_time_warn" {
id = "API-ResponseTimeWarn"
tags = {}
# (22 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# aws_cloudwatch_metric_alarm.idp_bounce_rate_high[0] has moved to aws_cloudwatch_metric_alarm.idp_bounce_rate_high
resource "aws_cloudwatch_metric_alarm" "idp_bounce_rate_high" {
id = "IdP-SESBounceRate"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.idp_complaint_rate_high[0] has moved to aws_cloudwatch_metric_alarm.idp_complaint_rate_high
resource "aws_cloudwatch_metric_alarm" "idp_complaint_rate_high" {
id = "IdP-SESComplaintRate"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.idp_cpu_utilization_high_warn[0] has moved to aws_cloudwatch_metric_alarm.idp_cpu_utilization_high_warn
resource "aws_cloudwatch_metric_alarm" "idp_cpu_utilization_high_warn" {
id = "IdP-CpuUtilizationWarn"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.idp_memory_utilization_high_warn[0] has moved to aws_cloudwatch_metric_alarm.idp_memory_utilization_high_warn
resource "aws_cloudwatch_metric_alarm" "idp_memory_utilization_high_warn" {
id = "IdP-MemoryUtilizationWarn"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.idp_rds_cpu_utilization[0] has moved to aws_cloudwatch_metric_alarm.idp_rds_cpu_utilization
resource "aws_cloudwatch_metric_alarm" "idp_rds_cpu_utilization" {
id = "IdP-RDSCpuUtilization"
tags = {}
# (22 unchanged attributes hidden)
}
# aws_cloudwatch_metric_alarm.idp_response_time_warn[0] has moved to aws_cloudwatch_metric_alarm.idp_response_time_warn
resource "aws_cloudwatch_metric_alarm" "idp_response_time_warn" {
id = "IdP-ResponseTimeWarn"
tags = {}
# (22 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.athena_bucket.aws_s3_bucket.this,
on .terraform/modules/athena_bucket/S3/main.tf line 8, in resource "aws_s3_bucket" "this":
8: resource "aws_s3_bucket" "this" {
Use the aws_s3_bucket_server_side_encryption_configuration resource instead
(and 3 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_athena_data_catalog.dynamodb"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_data_catalog.rds_data_catalog"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.codedeploy_sns"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notify_slack"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ELB_5xx_error_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ELB_healthy_hosts"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.UnHealthyHostCount-TargetGroup1"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.UnHealthyHostCount-TargetGroup2"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.api_audit_log_dead_letter_queue_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.api_cpu_utilization_high_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.api_lb_healthy_host_count"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.api_lb_unhealthy_host_count"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.api_memory_utilization_high_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.api_response_time_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.audit_log_dead_letter_queue_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cognito_login_outside_canada_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cognito_signin_exceeded"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ddos_detected_forms_warn"]
WARN - plan.json - main - Missing Common Tags:... |
|
🤖 Created releases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
3.23.1 (2024-09-23)
Bug Fixes
ecsmodule to stop task revision flip-flop (#842) (d2b9882)Miscellaneous Chores
context canceledIdP errors (#836) (b5fd220)This PR was generated with Release Please. See documentation.