Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/send delivery receipt for INTERNAL_TEST sms #2323

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Oct 9, 2024

Summary | Résumé

Broke the smoke test in #2320 because we stopped sending a delivery receipt for SMS to INTERNAL_TEST_NUMBER.
Here we add it back in.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Verify in staging that the smoke test works (ie SMS to 16135550123 are marked "delivered")

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels merged commit 248d4db into main Oct 9, 2024
4 checks passed
@sastels sastels deleted the fix-internal-test-number-delivery branch October 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants