feat: Conditional Input History - Form Builder (#3859)

* Adds initial work * Fixes a type * Adds util function for cleaning values * Adds util to remove non form values * Fixes a merge error * Fixes a unit test * Adds initial happy path unit test * Adds todo comments * Adds a check for an edge case * Updates fixture and more tests * Adds more unit tests * Adds unit test with answered questions * Fixes a unit test * Updates a comments * Reafactors tests and adds a fixture * Refactors fixtures into separate files * Adds unit test for a complex form case * Adds a newline at the end of some files * Refactoring function names * Adds a util method * Fixes a unittest * Removes commented out dependencies * Fixes issue with empty checkboxes * Refactors review page to be a bit more readable * Adds initial showhide logic values filtering * Refactors review part 1 * Refactors review page part 2 * Refactors review part 3 * Refactors review part 4 * Refactors review part 5 * Fixes unit tests * Refactors review part 6 * Refactors review part 7 * Adds unit test for filterShownElements * Adds more unit tests * Reverts Forms-form for a future PR * Code review part 1 Co-authored-by: Tim Arney <[email protected]> * Refactors review page to be more readable Co-authored-by: Tim Arney <[email protected]> * Refactors groupHistory utils with more descriptive names * Refactors group history utils with clearer names * Fixes a test * Updates unit tests --------- Co-authored-by: Tim Arney <[email protected]>
cds-snc · Jul 19, 2024 · 5b6c525 · 5b6c525
1 parent ea4f6d2
commit 5b6c525
Show file tree

Hide file tree

Showing 19 changed files with 2,083 additions and 88 deletions.
diff --git a/__fixtures__/conditionalInputHistoryComplex.json b/__fixtures__/conditionalInputHistoryComplex.json
@@ -0,0 +1,257 @@
+{
+  "values": {
+    "3": "I am applying for myself",
+    "4": "Yes",
+    "5": "11/11/1977",
+    "8": "1",
+    "10": "1",
+    "11": "1111111",
+    "12": "Single",
+    "14": "1",
+    "15": "1",
+    "17": "1",
+    "18": "1",
+    "19": "1",
+    "20": "1",
+    "22": "",
+    "23": "",
+    "24": "",
+    "25": "",
+    "26": "Canada",
+    "27": "Yes",
+    "29": "English",
+    "30": "Email",
+    "31": "[email protected]",
+    "32": "[email protected]",
+    "35": "",
+    "36": "",
+    "38": "Yes",
+    "40": "Yes, I have federal benefits",
+    "41": "Yes, I have provincial or territorial benefits",
+    "43": "Non-Insured Health Benefits Program by Indigenous Services Canada",
+    "44": "Alberta",
+    "45": "Alberta Child Health Benefits",
+    "46": "",
+    "47": "",
+    "48": "",
+    "49": "",
+    "50": "",
+    "51": "",
+    "52": "",
+    "53": "",
+    "54": "",
+    "55": "",
+    "56": "",
+    "57": "",
+    "62": "",
+    "64": "",
+    "65": "",
+    "66": "",
+    "67": [],
+    "currentGroup": "review",
+    "groupHistory": [
+      "start",
+      "6e0a9eb6-4f2b-4e3b-b461-2ffc27cf15ae",
+      "058df0aa-b89c-431c-bbe1-15bcd657ef35",
+      "d0482786-8aa6-4143-9309-0b659b27d9bc",
+      "d745959f-d9b3-4ca7-8eca-a1f5443864ea",
+      "50ee6ed1-e664-4577-bf21-f69cb9c234b6",
+      "63f6417e-40e0-42e8-b432-6cd090115b71",
+      "80650382-44f8-4a1f-9d75-f987d67d0d9d",
+      "586a8562-1528-4f0c-bdf9-52f3cf0c264b",
+      "review"
+    ]
+  },
+  "groups": {
+    "start": {
+      "name": "Start",
+      "titleEn": "Start",
+      "titleFr": "Début",
+      "elements": ["1", "2"],
+      "nextAction": "6e0a9eb6-4f2b-4e3b-b461-2ffc27cf15ae",
+      "autoFlow": true
+    },
+    "6e0a9eb6-4f2b-4e3b-b461-2ffc27cf15ae": {
+      "name": "Type of Application",
+      "elements": ["3"],
+      "titleEn": "Type of Application",
+      "titleFr": "Type de demande",
+      "nextAction": [
+        {
+          "groupId": "058df0aa-b89c-431c-bbe1-15bcd657ef35",
+          "choiceId": "3.0"
+        },
+        {
+          "groupId": "9dc6671e-0207-478b-8c2c-609c15ba0acd",
+          "choiceId": "3.1"
+        }
+      ],
+      "autoFlow": false
+    },
+    "9dc6671e-0207-478b-8c2c-609c15ba0acd": {
+      "name": "Apply for someone else",
+      "elements": ["58"],
+      "titleEn": "Applying on behalf of someone cannot be completed online at this time\n",
+      "titleFr": "La demande au nom d'une autre personne ne peut pas être effectuée en ligne pour le moment.\n",
+      "nextAction": "review",
+      "autoFlow": false
+    },
+    "058df0aa-b89c-431c-bbe1-15bcd657ef35": {
+      "name": "Tax filing",
+      "elements": ["4"],
+      "titleEn": "Tax filing",
+      "titleFr": "Déclaration d'impôts",
+      "nextAction": [
+        {
+          "groupId": "d0482786-8aa6-4143-9309-0b659b27d9bc",
+          "choiceId": "4.0"
+        },
+        {
+          "groupId": "7e92f4d7-a6fb-4055-8c57-fb6fcbe2ed60",
+          "choiceId": "4.1"
+        }
+      ],
+      "autoFlow": false
+    },
+    "7e92f4d7-a6fb-4055-8c57-fb6fcbe2ed60": {
+      "name": "File your taxes",
+      "elements": ["59"],
+      "titleEn": "File your taxes\n",
+      "titleFr": "Produire votre déclaration de revenus",
+      "nextAction": "review",
+      "autoFlow": false
+    },
+    "d0482786-8aa6-4143-9309-0b659b27d9bc": {
+      "name": "Date of Birth",
+      "elements": ["6", "5"],
+      "titleEn": "Date of Birth",
+      "titleFr": "Date de naissance",
+      "nextAction": "d745959f-d9b3-4ca7-8eca-a1f5443864ea",
+      "autoFlow": true
+    },
+    "d745959f-d9b3-4ca7-8eca-a1f5443864ea": {
+      "name": "Applicant Information",
+      "elements": ["7", "8", "10", "11", "12"],
+      "titleEn": "Applicant Information",
+      "titleFr": "Informations sur le demandeur",
+      "nextAction": [
+        {
+          "groupId": "a3b46349-66cc-4153-95ee-7d3a17373bd4",
+          "choiceId": "12.2"
+        },
+        {
+          "groupId": "a3b46349-66cc-4153-95ee-7d3a17373bd4",
+          "choiceId": "12.1"
+        },
+        {
+          "groupId": "50ee6ed1-e664-4577-bf21-f69cb9c234b6",
+          "choiceId": "12.catch-all"
+        }
+      ],
+      "autoFlow": false
+    },
+    "a3b46349-66cc-4153-95ee-7d3a17373bd4": {
+      "name": "Spouse or Common-law partner information",
+      "elements": ["60", "62", "64", "65", "66", "67"],
+      "titleEn": "Spouse or Common-law partner information\n",
+      "titleFr": "Renseignements sur l'époux/épouse ou le conjoint/conjointe de fait\n",
+      "nextAction": "50ee6ed1-e664-4577-bf21-f69cb9c234b6",
+      "autoFlow": true
+    },
+    "50ee6ed1-e664-4577-bf21-f69cb9c234b6": {
+      "name": "Personal Information",
+      "elements": [
+        "13",
+        "14",
+        "15",
+        "16",
+        "17",
+        "18",
+        "19",
+        "26",
+        "20",
+        "27",
+        "21",
+        "22",
+        "23",
+        "24",
+        "25"
+      ],
+      "titleEn": "Personal Information",
+      "titleFr": "Renseignements personnels",
+      "nextAction": "63f6417e-40e0-42e8-b432-6cd090115b71",
+      "autoFlow": true
+    },
+    "63f6417e-40e0-42e8-b432-6cd090115b71": {
+      "name": "Communication",
+      "elements": ["28", "29", "30", "34", "31", "32", "33", "36", "35"],
+      "titleEn": "Communication",
+      "titleFr": "Communication",
+      "nextAction": "80650382-44f8-4a1f-9d75-f987d67d0d9d",
+      "autoFlow": true
+    },
+    "80650382-44f8-4a1f-9d75-f987d67d0d9d": {
+      "name": "Access to other dental insurance",
+      "elements": ["37", "38"],
+      "titleEn": "Access to other dental insurance",
+      "titleFr": "Accès à d'autres assurances dentaires",
+      "nextAction": "586a8562-1528-4f0c-bdf9-52f3cf0c264b",
+      "autoFlow": true
+    },
+    "586a8562-1528-4f0c-bdf9-52f3cf0c264b": {
+      "name": "Access to other federal, provincial or territorial dental benefits",
+      "elements": [
+        "39",
+        "40",
+        "43",
+        "42",
+        "41",
+        "44",
+        "45",
+        "46",
+        "47",
+        "48",
+        "49",
+        "57",
+        "50",
+        "51",
+        "52",
+        "53",
+        "54",
+        "55",
+        "56"
+      ],
+      "titleEn": "Access to other federal, provincial or territorial dental benefits\n",
+      "titleFr": "Accès à d'autres prestations dentaires fédérales, provinciales ou territoriales\n",
+      "nextAction": "review",
+      "autoFlow": true
+    },
+    "review": {
+      "name": "Review",
+      "titleEn": "",
+      "titleFr": "",
+      "elements": [],
+      "nextAction": "end",
+      "autoFlow": true
+    },
+    "end": {
+      "name": "End",
+      "titleEn": "",
+      "titleFr": "",
+      "elements": [],
+      "autoFlow": true
+    }
+  },
+  "groupHistory": [
+    "start",
+    "6e0a9eb6-4f2b-4e3b-b461-2ffc27cf15ae",
+    "058df0aa-b89c-431c-bbe1-15bcd657ef35",
+    "d0482786-8aa6-4143-9309-0b659b27d9bc",
+    "d745959f-d9b3-4ca7-8eca-a1f5443864ea",
+    "50ee6ed1-e664-4577-bf21-f69cb9c234b6",
+    "63f6417e-40e0-42e8-b432-6cd090115b71",
+    "80650382-44f8-4a1f-9d75-f987d67d0d9d",
+    "586a8562-1528-4f0c-bdf9-52f3cf0c264b",
+    "review"
+  ]
+}
diff --git a/__fixtures__/conditionalInputHistoryEmptySimple.json b/__fixtures__/conditionalInputHistoryEmptySimple.json
@@ -0,0 +1,116 @@
+{
+  "values": {
+    "1": "A",
+    "2": [],
+    "3": "",
+    "4": "",
+    "5": "a1",
+    "6": "a2",
+    "7": "b1",
+    "8": "b2",
+    "9": "c1",
+    "10": "c2",
+    "11": "",
+    "12": "",
+    "13": [],
+    "14": "",
+    "15": "",
+    "currentGroup": "review",
+    "groupHistory": [
+      "start",
+      "1739f12e-abbd-46ae-9db6-1b4b2144080d",
+      "5205bacd-da93-4325-832e-9ed4be6ab38d",
+      "review"
+    ]
+  },
+  "groups": {
+    "start": {
+      "name": "Start",
+      "titleEn": "Beginning",
+      "titleFr": "Beginning",
+      "elements": ["1", "2", "3", "4", "11", "12", "15"],
+      "nextAction": [
+        {
+          "groupId": "1739f12e-abbd-46ae-9db6-1b4b2144080d",
+          "choiceId": "1.0"
+        },
+        {
+          "groupId": "911b3fa3-d6d7-4c67-96f8-3aa1f3eed0cf",
+          "choiceId": "1.1"
+        },
+        {
+          "groupId": "14b3be44-754a-45ae-9461-29c8af81d198",
+          "choiceId": "1.2"
+        }
+      ],
+      "autoFlow": false
+    },
+    "1739f12e-abbd-46ae-9db6-1b4b2144080d": {
+      "name": "A-S1",
+      "elements": ["5", "13"],
+      "titleEn": "A-S1",
+      "titleFr": "",
+      "nextAction": "5205bacd-da93-4325-832e-9ed4be6ab38d",
+      "autoFlow": true
+    },
+    "5205bacd-da93-4325-832e-9ed4be6ab38d": {
+      "name": "A-S2",
+      "elements": ["6", "14"],
+      "titleEn": "A-S2",
+      "titleFr": "",
+      "nextAction": "review",
+      "autoFlow": false
+    },
+    "911b3fa3-d6d7-4c67-96f8-3aa1f3eed0cf": {
+      "name": "B-S1",
+      "elements": ["7"],
+      "titleEn": "B-S1",
+      "titleFr": "",
+      "nextAction": "b6f9da0e-453d-4aab-b742-61652c50879f",
+      "autoFlow": true
+    },
+    "b6f9da0e-453d-4aab-b742-61652c50879f": {
+      "name": "B-S2",
+      "elements": ["8"],
+      "titleEn": "B-S2",
+      "titleFr": "",
+      "nextAction": "review",
+      "autoFlow": false
+    },
+    "14b3be44-754a-45ae-9461-29c8af81d198": {
+      "name": "C-S1",
+      "elements": ["9"],
+      "titleEn": "C-S1",
+      "titleFr": "",
+      "nextAction": "a066b786-6bd9-495b-ad4e-ba165d4be049",
+      "autoFlow": true
+    },
+    "a066b786-6bd9-495b-ad4e-ba165d4be049": {
+      "name": "C-S2",
+      "elements": ["10"],
+      "titleEn": "C-S2",
+      "titleFr": "",
+      "nextAction": "review",
+      "autoFlow": false
+    },
+    "review": {
+      "name": "Review",
+      "titleEn": "Review",
+      "titleFr": "Review",
+      "elements": [],
+      "nextAction": "end"
+    },
+    "end": {
+      "name": "End",
+      "titleEn": "End",
+      "titleFr": "End",
+      "elements": []
+    }
+  },
+  "groupHistory": [
+    "start",
+    "1739f12e-abbd-46ae-9db6-1b4b2144080d",
+    "5205bacd-da93-4325-832e-9ed4be6ab38d",
+    "review"
+  ]
+}