-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node version #2820
Conversation
🧪 Review environmenthttps://o7po4cuz4vzmh4l2gxfcm4ueee0zevlp.lambda-url.ca-central-1.on.aws/ |
…latform-forms-client into chore/new_node_version
As part of this update maybe add an .nvmrc file so we can all use the same version within the repo? |
Great idea! Will do. |
@bryan-robitaille looks like the updated |
yes please. I didn't update the yarn.lock after removing node-gyp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Looks good - just re-running the jest tests . |
Summary | Résumé
chores:
Test instructions | Instructions pour tester la modification
All tests should pass
Pull Request Checklist
Please complete the following items in the checklist before you request a review: