Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node version #2820

Merged
merged 13 commits into from
Nov 3, 2023
Merged

chore: update node version #2820

merged 13 commits into from
Nov 3, 2023

Conversation

bryan-robitaille
Copy link
Contributor

@bryan-robitaille bryan-robitaille commented Nov 2, 2023

Summary | Résumé

chores:

  • update to node 18
  • add memory limiter for jest ( jest docs )

Test instructions | Instructions pour tester la modification

All tests should pass

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Copy link
Contributor

github-actions bot commented Nov 2, 2023

@bryan-robitaille bryan-robitaille marked this pull request as ready for review November 3, 2023 17:58
package.json Outdated Show resolved Hide resolved
@timarney
Copy link
Member

timarney commented Nov 3, 2023

As part of this update maybe add an .nvmrc file so we can all use the same version within the repo?

https://github.com/nvm-sh/nvm#nvmrc

@bryan-robitaille
Copy link
Contributor Author

As part of this update maybe add an .nvmrc file so we can all use the same version within the repo?

https://github.com/nvm-sh/nvm#nvmrc

Great idea! Will do.

@craigzour
Copy link
Contributor

craigzour commented Nov 3, 2023

@bryan-robitaille looks like the updated yarn.lock included in the pull request is not in sync with the one that is generated locally when I am testing your branch. I can commit mine if you would like!

@bryan-robitaille
Copy link
Contributor Author

@bryan-robitaille looks like the updated yarn.lock included in the pull request is not in sync with the one that is generated locally when I am testing your branch. I can commit mine if you would like!

yes please. I didn't update the yarn.lock after removing node-gyp

Copy link
Contributor

@craigzour craigzour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@timarney
Copy link
Member

timarney commented Nov 3, 2023

Looks good - just re-running the jest tests .

@bryan-robitaille bryan-robitaille enabled auto-merge (squash) November 3, 2023 19:33
@bryan-robitaille bryan-robitaille merged commit 2ddb535 into develop Nov 3, 2023
11 checks passed
@bryan-robitaille bryan-robitaille deleted the chore/new_node_version branch November 3, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants